Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2829073002: MIPS64: Move load/store instructions to macro-assembler. (Closed)

Created:
3 years, 8 months ago by Ilija.Pavlovic1
Modified:
3 years, 8 months ago
Reviewers:
ivica.bogosavljevic, Ilija.Pavlovic1, miran.karic
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Move load/store instructions to macro-assembler. For MIPS64, many load/store operations from/to memory emit more then one instruction. This is the reason for moving them from assembler to macro-assembler. TEST= BUG= Review-Url: https://codereview.chromium.org/2829073002 Cr-Commit-Position: refs/heads/master@{#44746} Committed: https://chromium.googlesource.com/v8/v8/+/cc797ac06cad5e6e2ec2735f4648004c87066c83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1854 lines, -1757 lines) Patch
M src/builtins/mips64/builtins-mips64.cc View 98 chunks +208 lines, -208 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 20 chunks +54 lines, -54 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 88 chunks +139 lines, -143 lines 0 comments Download
M src/crankshaft/mips64/lithium-gap-resolver-mips64.cc View 7 chunks +23 lines, -24 lines 0 comments Download
M src/debug/mips64/debug-mips64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 60 chunks +101 lines, -101 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 8 chunks +21 lines, -22 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 6 chunks +19 lines, -127 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 73 chunks +137 lines, -141 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 13 chunks +90 lines, -90 lines 0 comments Download
M src/mips64/constants-mips64.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/mips64/deoptimizer-mips64.cc View 12 chunks +29 lines, -29 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 11 chunks +53 lines, -28 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 96 chunks +372 lines, -181 lines 0 comments Download
M src/regexp/mips64/regexp-macro-assembler-mips64.cc View 39 chunks +77 lines, -77 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 73 chunks +489 lines, -491 lines 0 comments Download
M test/cctest/test-code-stubs-mips64.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 8 chunks +31 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ilija.Pavlovic1
PTAL
3 years, 8 months ago (2017-04-20 13:11:43 UTC) #2
ivica.bogosavljevic
lgtm
3 years, 8 months ago (2017-04-20 13:17:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829073002/1
3 years, 8 months ago (2017-04-20 13:19:31 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 13:45:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cc797ac06cad5e6e2ec2735f4648004c870...

Powered by Google App Engine
This is Rietveld 408576698