Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2829013004: Add Incognito Navigation histograms (Closed)

Created:
3 years, 8 months ago by elawrence
Modified:
3 years, 8 months ago
Reviewers:
Mark P, mpearson, davidben
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Add Incognito Navigation histograms As a part of scoping changes to behavior, we want to collect the absolute number of page navigations in Incognito mode. Modified tests for M59. BUG=712843 TEST=components_unittests --gtest_filter=NavigationMetrics*.* TBR=mpearson@google.com, davidben@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2827983003 Cr-Commit-Position: refs/heads/master@{#466140} (cherry picked from commit 16908bf6ea4341513c47b4c861a2408c55941a30) Review-Url: https://codereview.chromium.org/2829013004 Cr-Commit-Position: refs/branch-heads/3071@{#137} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/77447721b2d2531e5ff2e2ea364ab044eb1e4ce4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -4 lines) Patch
M components/navigation_metrics/navigation_metrics.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M components/navigation_metrics/navigation_metrics_unittest.cc View 3 chunks +35 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
elawrence
Merging to M59. Original reviewers as TBR as it's not a perfectly-clean cherry pick (had ...
3 years, 8 months ago (2017-04-21 23:27:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829013004/1
3 years, 8 months ago (2017-04-21 23:29:01 UTC) #6
Mark P
histograms.xml still lgtm
3 years, 8 months ago (2017-04-21 23:29:02 UTC) #9
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 8 months ago (2017-04-21 23:29:03 UTC) #10
davidben
lgtm
3 years, 8 months ago (2017-04-21 23:29:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829013004/1
3 years, 8 months ago (2017-04-21 23:30:52 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 23:33:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77447721b2d2531e5ff2e2ea364a...

Powered by Google App Engine
This is Rietveld 408576698