Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2828973002:
Add a unit test for Issue 711703 (Closed)
DescriptionAdd a unit test for Issue 711703
BUG=711703
Review-Url: https://codereview.chromium.org/2828973002
Cr-Commit-Position: refs/heads/master@{#466903}
Committed: https://chromium.googlesource.com/chromium/src/+/f0aff0ca64ae1f50b4deeea5966b0ad025323696
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #
Depends on Patchset: Messages
Total messages: 24 (18 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Description was changed from ========== Add a unit test for Issue 711703 BUG= ========== to ========== Add a unit test for Issue 711703 BUG=711703 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hiroshige@chromium.org changed reviewers: + kouhei@chromium.org, vogelheim@chromium.org
PTAL. This is a regression test for https://codereview.chromium.org/2653923008/. However, to reduce rebasing, I'll commit this after https://codereview.chromium.org/2653923008/ is landed. I tested this unit test crashes if ClassicPendingScript's prefinalizer is removed.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
LGTM
lgtm
lgtm
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, vogelheim@chromium.org, kouhei@chromium.org Link to the patchset: https://codereview.chromium.org/2828973002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493102543006960,
"parent_rev": "3d792ae95a9b9e1efa7dfe380278182f94ac8755", "commit_rev":
"f0aff0ca64ae1f50b4deeea5966b0ad025323696"}
Message was sent while issue was closed.
Description was changed from ========== Add a unit test for Issue 711703 BUG=711703 ========== to ========== Add a unit test for Issue 711703 BUG=711703 Review-Url: https://codereview.chromium.org/2828973002 Cr-Commit-Position: refs/heads/master@{#466903} Committed: https://chromium.googlesource.com/chromium/src/+/f0aff0ca64ae1f50b4deeea5966b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/f0aff0ca64ae1f50b4deeea5966b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
