Fix background-attachment:local <li> crash during PrePaintTreeWalk

Fix background-attachment:local <li> crash during PrePaintTreeWalk

The crash was because of the SetShouldDoFullPaintInvalidation() call
during PrePaint while the ancestors didn't updated paint property
builder contexts.

(We still allow SetShouldDoFullPaintInvalidation() call during PrePaint
given that ancestors have updated their paint property builder contexts.
A case is on SPv2 when paint offset changes -- we are already updating
paint property builder context, so the SetShouldDoFullPaintInvalidation
call is valid. Invalid calls can be caught by the DCHECKs.)

BUG=709798
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2823963002
Cr-Commit-Position: refs/heads/master@{#465405}

TBR=wangxianzhu@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2828963002
Cr-Commit-Position: refs/branch-heads/3071@{#70}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/1d9c07cad47b873b86556ef54e2b64a962f1f713

[Xianzhu, 2017-04-19 23:08:27]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-04-19 23:08:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 23:09:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492643307857940, "parent_rev":
"89bfdc09da805adc9bb85bfcb4e38e62bb3d2833", "commit_rev":
"1d9c07cad47b873b86556ef54e2b64a962f1f713"}

[commit-bot: I haz the power, 2017-04-19 23:09:41]

Description was changed from

==========
Fix background-attachment:local <li> crash during PrePaintTreeWalk

The crash was because of the SetShouldDoFullPaintInvalidation() call
during PrePaint while the ancestors didn't updated paint property
builder contexts.

(We still allow SetShouldDoFullPaintInvalidation() call during PrePaint
given that ancestors have updated their paint property builder contexts.
A case is on SPv2 when paint offset changes -- we are already updating
paint property builder context, so the SetShouldDoFullPaintInvalidation
call is valid. Invalid calls can be caught by the DCHECKs.)

BUG=709798
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2823963002
Cr-Commit-Position: refs/heads/master@{#465405}

TBR=wangxianzhu@chromium.org
NOPRESUBMIT=true
NOTRY=true
==========

to

==========
Fix background-attachment:local <li> crash during PrePaintTreeWalk

The crash was because of the SetShouldDoFullPaintInvalidation() call
during PrePaint while the ancestors didn't updated paint property
builder contexts.

(We still allow SetShouldDoFullPaintInvalidation() call during PrePaint
given that ancestors have updated their paint property builder contexts.
A case is on SPv2 when paint offset changes -- we are already updating
paint property builder context, so the SetShouldDoFullPaintInvalidation
call is valid. Invalid calls can be caught by the DCHECKs.)

BUG=709798
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2823963002
Cr-Commit-Position: refs/heads/master@{#465405}

TBR=wangxianzhu@chromium.org
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2828963002
Cr-Commit-Position: refs/branch-heads/3071@{#70}
Cr-Branched-From:
a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d9c07cad47b873b86556ef54e2b...
==========

[commit-bot: I haz the power, 2017-04-19 23:09:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d9c07cad47b873b86556ef54e2b...