Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2823963002:
Fix background-attachment:local <li> crash during PrePaintTreeWalk (Closed)
|
Created:
3 years, 8 months ago by Xianzhu Modified:
3 years, 8 months ago Reviewers:
pdr. CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix background-attachment:local <li> crash during PrePaintTreeWalk
The crash was because of the SetShouldDoFullPaintInvalidation() call
during PrePaint while the ancestors didn't updated paint property
builder contexts.
(We still allow SetShouldDoFullPaintInvalidation() call during PrePaint
given that ancestors have updated their paint property builder contexts.
A case is on SPv2 when paint offset changes -- we are already updating
paint property builder context, so the SetShouldDoFullPaintInvalidation
call is valid. Invalid calls can be caught by the DCHECKs.)
BUG=709798
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2823963002
Cr-Commit-Position: refs/heads/master@{#465405}
Committed: https://chromium.googlesource.com/chromium/src/+/a90d70bc3c688ca28d02aaf56fc25e2c2308960e
Patch Set 1 #Patch Set 2 : - #Patch Set 3 : - #Patch Set 4 : - #Patch Set 5 : - #
Messages
Total messages: 29 (25 generated)
Description was changed from ========== Fix background-attachment:local <li> crash during PrePaintTreeWalk BUG=709798 ========== to ========== Fix background-attachment:local <li> crash during PrePaintTreeWalk BUG=709798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix background-attachment:local <li> crash during PrePaintTreeWalk BUG=709798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Fix background-attachment:local <li> crash during PrePaintTreeWalk The crash was because of the SetShouldDoFullPaintInvalidation() call during PrePaint while the ancestors didn't updated paint property builder contexts. (We still allow SetShouldDoFullPaintInvalidation() call during PrePaint given that ancestors have updated their paint property builder contexts. A case is on SPv2 when paint offset changes -- we are already updating paint property builder context, so the SetShouldDoFullPaintInvalidation call is valid. Invalid calls can be caught by the DCHECKs.) BUG=709798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
wangxianzhu@chromium.org changed reviewers: + pdr@chromium.org
On 2017/04/18 at 21:01:33, wangxianzhu wrote: > LGTM
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492550199359250,
"parent_rev": "85312ee5ec5652a88b9b345d53f92ae261a0d451", "commit_rev":
"a90d70bc3c688ca28d02aaf56fc25e2c2308960e"}
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492550199359250,
"parent_rev": "85312ee5ec5652a88b9b345d53f92ae261a0d451", "commit_rev":
"a90d70bc3c688ca28d02aaf56fc25e2c2308960e"}
Message was sent while issue was closed.
Description was changed from ========== Fix background-attachment:local <li> crash during PrePaintTreeWalk The crash was because of the SetShouldDoFullPaintInvalidation() call during PrePaint while the ancestors didn't updated paint property builder contexts. (We still allow SetShouldDoFullPaintInvalidation() call during PrePaint given that ancestors have updated their paint property builder contexts. A case is on SPv2 when paint offset changes -- we are already updating paint property builder context, so the SetShouldDoFullPaintInvalidation call is valid. Invalid calls can be caught by the DCHECKs.) BUG=709798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Fix background-attachment:local <li> crash during PrePaintTreeWalk The crash was because of the SetShouldDoFullPaintInvalidation() call during PrePaint while the ancestors didn't updated paint property builder contexts. (We still allow SetShouldDoFullPaintInvalidation() call during PrePaint given that ancestors have updated their paint property builder contexts. A case is on SPv2 when paint offset changes -- we are already updating paint property builder context, so the SetShouldDoFullPaintInvalidation call is valid. Invalid calls can be caught by the DCHECKs.) BUG=709798 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2823963002 Cr-Commit-Position: refs/heads/master@{#465405} Committed: https://chromium.googlesource.com/chromium/src/+/a90d70bc3c688ca28d02aaf56fc2... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/a90d70bc3c688ca28d02aaf56fc2... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
