Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2828903002: Reland of Disable flaky WebNavigationApiTest.CrossProcessHistory. (Closed)

Created:
3 years, 8 months ago by Roger McFarlane (Chromium)
Modified:
3 years, 8 months ago
Reviewers:
Max Morin, nasko
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2830813002/ ) Reason for revert: The flakiness came back upon landing this revert. So, reverting the revert. Original issue's description: > Revert of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2790383002/ ) > > Reason for revert: > What I believe was the underlying issue has been reverted, so it should be safe to reenable this test back. > > Original issue's description: > > Disable flaky WebNavigationApiTest.CrossProcessHistory. > > > > TBR=nasko@chromium.org > > BUG=708139 > > > > Review-Url: https://codereview.chromium.org/2790383002 > > Cr-Commit-Position: refs/heads/master@{#461690} > > Committed: https://chromium.googlesource.com/chromium/src/+/656fccff69eae8da012f0f83bcd3fc89214c5258 > > TBR=maxmorin@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=708139 > > Review-Url: https://codereview.chromium.org/2830813002 > Cr-Commit-Position: refs/heads/master@{#465709} > Committed: https://chromium.googlesource.com/chromium/src/+/ccdcc6ef79a614b1b1c87a78a883d9c5b19ffde2 TBR=maxmorin@chromium.org,nasko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=708139 Review-Url: https://codereview.chromium.org/2828903002 Cr-Commit-Position: refs/heads/master@{#465748} Committed: https://chromium.googlesource.com/chromium/src/+/a4be5c7090175b7410f2a9adcb447a111d152c94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Roger McFarlane (Chromium)
Created Reland of Disable flaky WebNavigationApiTest.CrossProcessHistory.
3 years, 8 months ago (2017-04-19 21:05:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828903002/1
3 years, 8 months ago (2017-04-19 21:06:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a4be5c7090175b7410f2a9adcb447a111d152c94
3 years, 8 months ago (2017-04-19 21:15:25 UTC) #6
Max Morin
3 years, 8 months ago (2017-04-20 07:05:27 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698