Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2830813002: Revert of Disable flaky WebNavigationApiTest.CrossProcessHistory. (Closed)

Created:
3 years, 8 months ago by nasko
Modified:
3 years, 8 months ago
Reviewers:
Max Morin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky WebNavigationApiTest.CrossProcessHistory. (patchset #1 id:1 of https://codereview.chromium.org/2790383002/ ) Reason for revert: What I believe was the underlying issue has been reverted, so it should be safe to reenable this test back. Original issue's description: > Disable flaky WebNavigationApiTest.CrossProcessHistory. > > TBR=nasko@chromium.org > BUG=708139 > > Review-Url: https://codereview.chromium.org/2790383002 > Cr-Commit-Position: refs/heads/master@{#461690} > Committed: https://chromium.googlesource.com/chromium/src/+/656fccff69eae8da012f0f83bcd3fc89214c5258 TBR=maxmorin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=708139 Review-Url: https://codereview.chromium.org/2830813002 Cr-Commit-Position: refs/heads/master@{#465709} Committed: https://chromium.googlesource.com/chromium/src/+/ccdcc6ef79a614b1b1c87a78a883d9c5b19ffde2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nasko
Created Revert of Disable flaky WebNavigationApiTest.CrossProcessHistory.
3 years, 8 months ago (2017-04-19 18:53:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830813002/1
3 years, 8 months ago (2017-04-19 18:54:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ccdcc6ef79a614b1b1c87a78a883d9c5b19ffde2
3 years, 8 months ago (2017-04-19 19:35:58 UTC) #6
Roger McFarlane (Chromium)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2828903002/ by rogerm@chromium.org. ...
3 years, 8 months ago (2017-04-19 21:05:23 UTC) #7
Max Morin
3 years, 8 months ago (2017-04-20 07:05:14 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698