ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc - Issue 2828843002: Fix unsafe destruction order of InputDeviceFactoryEvdev

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

Issue 2828843002: Fix unsafe destruction order of InputDeviceFactoryEvdev (Closed)

Patch Set: fix some more dchecks Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

diff --git a/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc b/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

index 5914791ad59f44cb14a48cafcec2fb6c13e9cdcd..274c7441b1e955e0e87b8bfd969c5611a389fcd2 100644

--- a/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

+++ b/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

@@ -65,7 +65,7 @@ EventReaderLibevdevCros::EventReaderLibevdevCros(

}

EventReaderLibevdevCros::~EventReaderLibevdevCros() {

- DCHECK(!watching_);

+ Stop();

EvdevClose(&evdev_);

}

« no previous file with comments | « ui/events/ozone/evdev/input_device_factory_evdev.h ('k') | no next file » | no next file with comments »