Detect duplicate recipe tests

Detect duplicate recipe tests

BUG=chromium:713267
Review-Url: https://codereview.chromium.org/2828823003
Committed: https://github.com/luci/recipes-py/commit/650286105fc31ca1d053b1dd20cb67642b80ac75

[Paweł Hajdan Jr., 2017-04-19 18:07:18]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 18:07:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 18:10:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 18:10:53]

Dry run: This issue passed the CQ dry run.

[iannucci1, 2017-04-19 18:12:42]

iannucci@google.com changed reviewers:
+ iannucci@google.com

[iannucci1, 2017-04-19 18:12:43]

lgtm

https://codereview.chromium.org/2828823003/diff/1/recipe_engine/test.py
File recipe_engine/test.py (right):

https://codereview.chromium.org/2828823003/diff/1/recipe_engine/test.py#newco...
recipe_engine/test.py:414: raise ValueError('Duplicate test found: %s' %
test_data.name)
I think the error should indicate which recipe the duplicate test was found in,
too (unless that's automatically added somewhere else somehow?)

[Paweł Hajdan Jr., 2017-04-19 18:17:06]

https://codereview.chromium.org/2828823003/diff/1/recipe_engine/test.py
File recipe_engine/test.py (right):

https://codereview.chromium.org/2828823003/diff/1/recipe_engine/test.py#newco...
recipe_engine/test.py:414: raise ValueError('Duplicate test found: %s' %
test_data.name)
On 2017/04/19 18:12:42, iannucci1 wrote:
> I think the error should indicate which recipe the duplicate test was found
in,
> too (unless that's automatically added somewhere else somehow?)

It does, please see the test:

Exception: While generating results for 'foo': ValueError: Duplicate test found:
basic

[iannucci1, 2017-04-19 18:17:55]

On 2017/04/19 18:17:06, Paweł Hajdan Jr. wrote:
> https://codereview.chromium.org/2828823003/diff/1/recipe_engine/test.py
> File recipe_engine/test.py (right):
> 
>
https://codereview.chromium.org/2828823003/diff/1/recipe_engine/test.py#newco...
> recipe_engine/test.py:414: raise ValueError('Duplicate test found: %s' %
> test_data.name)
> On 2017/04/19 18:12:42, iannucci1 wrote:
> > I think the error should indicate which recipe the duplicate test was found
> in,
> > too (unless that's automatically added somewhere else somehow?)
> 
> It does, please see the test:
> 
> Exception: While generating results for 'foo': ValueError: Duplicate test
found:
> basic

lgtm

[iannucci, 2017-04-19 18:18:08]

iannucci@chromium.org changed reviewers:
+ iannucci@chromium.org

[iannucci, 2017-04-19 18:18:09]

lgtm

[Paweł Hajdan Jr., 2017-04-19 18:18:40]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2017-04-19 18:18:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 18:21:53]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492625920600050, "parent_rev":
"95d0ea9d52f42965db876058ead6a8c619d1f853", "commit_rev":
"650286105fc31ca1d053b1dd20cb67642b80ac75"}

[commit-bot: I haz the power, 2017-04-19 18:21:57]

Description was changed from

==========
Detect duplicate recipe tests

BUG=chromium:713267
==========

to

==========
Detect duplicate recipe tests

BUG=chromium:713267

Review-Url: https://codereview.chromium.org/2828823003
Committed:
https://github.com/luci/recipes-py/commit/650286105fc31ca1d053b1dd20cb67642b8...
==========

[commit-bot: I haz the power, 2017-04-19 18:21:58]

Committed patchset #1 (id:1) as
https://github.com/luci/recipes-py/commit/650286105fc31ca1d053b1dd20cb67642b8...