Detect duplicate recipe tests

recipe_engine/test.py

 # Copyright 2017 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 from __future__ import print_function
 
 import argparse
 import bdb
 import cStringIO
 import contextlib
@@ skipping 391 matching lines @@
         # the function definition, not GenTests body.
         recipe_tests = list(recipe.gen_tests(test_api))
       coverage_data.update(cov.get_data())
 
       for test_data in recipe_tests:
         # Put the test data in shared cache. This way it can only be generated
         # once. We do this primarily for _correctness_ , for example in case
         # a weird recipe generates tests non-deterministically. The recipe
         # engine should be robust against such user recipe code where
         # reasonable.
-        _GEN_TEST_CACHE[(recipe_name, test_data.name)] = copy.deepcopy(
-            test_data)
+        key = (recipe_name, test_data.name)
+        if key in _GEN_TEST_CACHE:
+          raise ValueError('Duplicate test found: %s' % test_data.name)

[iannucci1, 2017/04/19 18:12:42]

I think the error should indicate which recipe the duplicate test was found in,
too (unless that's automatically added somewhere else somehow?)

[Paweł Hajdan Jr., 2017/04/19 18:17:06]

It does, please see the test:

Exception: While generating results for 'foo': ValueError: Duplicate test found:
basic

+        _GEN_TEST_CACHE[key] = copy.deepcopy(test_data)
 
         test_description = TestDescription(
             recipe_name, test_data.name, expect_dir, covers)
         if test_filter:
           for pattern in test_filter:
             if fnmatch.fnmatch(test_description.full_name, pattern):
               tests.append(test_description)
               break
         else:
           tests.append(test_description)
@@ skipping 477 matching lines @@
   Returns:
     Exit code
   """
   global _UNIVERSE_VIEW
   _UNIVERSE_VIEW = universe_view
   global _ENGINE_FLAGS
   _ENGINE_FLAGS = engine_flags
 
   args = parse_args(raw_args)
   return args.func(args)