Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: webrtc/call/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Move out fec_test_helper from rtc_include_tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/BUILD.gn ('k') | webrtc/modules/audio_coding/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/BUILD.gn
diff --git a/webrtc/call/BUILD.gn b/webrtc/call/BUILD.gn
index b56b4a20f6d555f01ba2cd0508ba3b7914274a64..9cc3c186389f686f3d105a94fa1afb8a0839fa76 100644
--- a/webrtc/call/BUILD.gn
+++ b/webrtc/call/BUILD.gn
@@ -73,6 +73,13 @@ rtc_static_library("call") {
if (rtc_include_tests) {
rtc_source_set("call_tests") {
testonly = true
+
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc:video_engine_tests" ]
+ }
sources = [
"bitrate_allocator_unittest.cc",
"bitrate_estimator_tests.cc",
@@ -105,6 +112,13 @@ if (rtc_include_tests) {
rtc_source_set("call_perf_tests") {
testonly = true
+
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc:webrtc_perf_tests" ]
+ }
sources = [
"call_perf_tests.cc",
"rampup_tests.cc",
« no previous file with comments | « webrtc/base/BUILD.gn ('k') | webrtc/modules/audio_coding/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698