Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: webrtc/base/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Move out fec_test_helper from rtc_include_tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/audio/BUILD.gn ('k') | webrtc/call/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index 2a990e8ec2ee55d5be4e621baafe5313039c1789..6014809661234e6a2f9cc5987c87821f715b8a01 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -742,6 +742,13 @@ if (rtc_include_tests) {
rtc_source_set("rtc_base_nonparallel_tests") {
testonly = true
+
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc:webrtc_nonparallel_tests" ]
+ }
sources = [
"cpu_time_unittest.cc",
"filerotatingstream_unittest.cc",
@@ -769,6 +776,13 @@ if (rtc_include_tests) {
rtc_source_set("rtc_base_approved_unittests") {
testonly = true
+
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc:rtc_unittests" ]
+ }
sources = [
"array_view_unittest.cc",
"atomicops_unittest.cc",
@@ -820,6 +834,13 @@ if (rtc_include_tests) {
rtc_source_set("rtc_task_queue_unittests") {
testonly = true
+
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc:rtc_unittests" ]
+ }
sources = [
"sequenced_task_checker_unittest.cc",
"task_queue_unittest.cc",
@@ -837,6 +858,13 @@ if (rtc_include_tests) {
rtc_source_set("rtc_numerics_unittests") {
testonly = true
+
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc:rtc_unittests" ]
+ }
sources = [
"numerics/exp_filter_unittest.cc",
"numerics/percentile_filter_unittest.cc",
@@ -854,6 +882,13 @@ if (rtc_include_tests) {
}
rtc_source_set("rtc_base_unittests") {
testonly = true
+
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc:rtc_unittests" ]
+ }
sources = [
"callback_unittest.cc",
"crc32_unittest.cc",
« no previous file with comments | « webrtc/audio/BUILD.gn ('k') | webrtc/call/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698