Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: webrtc/modules/audio_coding/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Move out fec_test_helper from rtc_include_tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/call/BUILD.gn ('k') | webrtc/modules/audio_conference_mixer/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/BUILD.gn
diff --git a/webrtc/modules/audio_coding/BUILD.gn b/webrtc/modules/audio_coding/BUILD.gn
index 9c7e5eec5541adcaf514f73309e1857c78638cbc..4a2fdcaf87ef162c899b6cb382ef01cc3e52b415 100644
--- a/webrtc/modules/audio_coding/BUILD.gn
+++ b/webrtc/modules/audio_coding/BUILD.gn
@@ -1168,6 +1168,13 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_modules_tests") {
testonly = true
+
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc/modules:modules_tests" ]
+ }
sources = [
"test/APITest.cc",
"test/Channel.cc",
@@ -1212,6 +1219,13 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_perf_tests") {
testonly = true
+
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc:webrtc_perf_tests" ]
+ }
sources = [
"codecs/opus/opus_complexity_unittest.cc",
"neteq/test/neteq_performance_unittest.cc",
@@ -2015,6 +2029,12 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_unittests") {
testonly = true
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc/modules:modules_unittests" ]
+ }
sources = [
"acm2/acm_receiver_unittest.cc",
"acm2/audio_coding_module_unittest.cc",
« no previous file with comments | « webrtc/call/BUILD.gn ('k') | webrtc/modules/audio_conference_mixer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698