Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: webrtc/audio/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Move out fec_test_helper from rtc_include_tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/BUILD.gn ('k') | webrtc/base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/audio/BUILD.gn
diff --git a/webrtc/audio/BUILD.gn b/webrtc/audio/BUILD.gn
index 0de4229c7be8ce9416dfb8088cf23a9e4914d338..b3d4e1d89ef4052cd5e47bc1d4094b1345a8bf44 100644
--- a/webrtc/audio/BUILD.gn
+++ b/webrtc/audio/BUILD.gn
@@ -54,6 +54,13 @@ if (rtc_include_tests) {
rtc_source_set("audio_tests") {
testonly = true
+ # Skip restricting visibility on mobile platforms since the tests on those
+ # gets additional generated targets which would require many lines here to
+ # cover (which would be confusing to read and hard to maintain).
+ if (!is_android && !is_ios) {
+ visibility = [ "//webrtc:video_engine_tests" ]
+ }
+
# TODO(kjellander): Remove (bugs.webrtc.org/6828)
# This needs remote_bitrate_estimator to be moved to webrtc/api first.
check_includes = false
« no previous file with comments | « webrtc/api/BUILD.gn ('k') | webrtc/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698