Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h

Issue 2828643002: Make customElements.define faster
Patch Set: Remove some unneeded casts. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h b/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h
index 04ef2808de8af5d37a47cd9d69b9495fbdaf303e..63f7eb023fe74eff65f11336c293a439885e9154 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h
@@ -35,7 +35,8 @@ class TestCustomElementDefinitionBuilder
bool CheckConstructorNotRegistered() override { return true; }
bool CheckPrototype() override { return true; }
bool RememberOriginalProperties() override { return true; }
- CustomElementDefinition* Build(const CustomElementDescriptor&) override;
+ CustomElementDefinition* Build(const CustomElementDescriptor&,
+ CustomElementDefinition::Id) override;
};
class TestCustomElementDefinition : public CustomElementDefinition {
@@ -46,8 +47,8 @@ class TestCustomElementDefinition : public CustomElementDefinition {
: CustomElementDefinition(descriptor) {}
TestCustomElementDefinition(const CustomElementDescriptor& descriptor,
- const HashSet<AtomicString>& observed_attributes)
- : CustomElementDefinition(descriptor, observed_attributes) {}
+ HashSet<AtomicString>&& observed_attributes)
+ : CustomElementDefinition(descriptor, std::move(observed_attributes)) {}
~TestCustomElementDefinition() override = default;

Powered by Google App Engine
This is Rietveld 408576698