third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.cpp - Issue 2828643002: Make customElements.define faster

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.cpp

Issue 2828643002: Make customElements.define faster

Patch Set: Remove some unneeded casts. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h ('k') | third_party/WebKit/Source/core/dom/custom/README.md » ('j') | third_party/WebKit/Source/platform/bindings/V8PerContextData.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.cpp

index 4a144738930d6de0303395633ce5d405e939bccd..09cdd77ca898eb2e93274717a9ebb3214e6193b2 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.cpp

@@ -7,7 +7,8 @@

namespace blink {

CustomElementDefinition* TestCustomElementDefinitionBuilder::Build(

- const CustomElementDescriptor& descriptor) {

+ const CustomElementDescriptor& descriptor,

+ CustomElementDefinition::Id) {

return new TestCustomElementDefinition(descriptor);

}