third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp - Issue 2828643002: Make customElements.define faster

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp

Issue 2828643002: Make customElements.define faster

Patch Set: Remove some unneeded casts. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementRegistry.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h » ('j') | third_party/WebKit/Source/platform/bindings/V8PerContextData.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp

index 79da0fc936297192c025343268f3c2000ef8ad05..083ed72d997d6f40bec1cc2ae814abb89bd15be7 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementRegistryTest.cpp

@@ -265,8 +265,8 @@ class LogUpgradeBuilder final : public TestCustomElementDefinitionBuilder {

public:

LogUpgradeBuilder() {}

- CustomElementDefinition* Build(

- const CustomElementDescriptor& descriptor) override {

+ CustomElementDefinition* Build(const CustomElementDescriptor& descriptor,

+ CustomElementDefinition::Id) override {

return new LogUpgradeDefinition(descriptor);

}

};