Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2828603002: Format samples and samples-dev directories. (Closed)

Created:
3 years, 8 months ago by Jacob
Modified:
3 years, 8 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1356 lines, -1205 lines) Patch
M samples-dev/swarm/App.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M samples-dev/swarm/BiIterator.dart View 2 chunks +1 line, -2 lines 0 comments Download
M samples-dev/swarm/CannedData.dart View 1 chunk +99 lines, -98 lines 0 comments Download
M samples-dev/swarm/ConfigHintDialog.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M samples-dev/swarm/DataSource.dart View 10 chunks +25 lines, -24 lines 0 comments Download
M samples-dev/swarm/Decoder.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M samples-dev/swarm/HelpDialog.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M samples-dev/swarm/SwarmApp.dart View 1 chunk +3 lines, -1 line 0 comments Download
M samples-dev/swarm/SwarmState.dart View 8 chunks +23 lines, -27 lines 0 comments Download
M samples-dev/swarm/SwarmViews.dart View 24 chunks +74 lines, -62 lines 0 comments Download
M samples-dev/swarm/UIState.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples-dev/swarm/Views.dart View 31 chunks +126 lines, -113 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/base/AnimationScheduler.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/base/Device.dart View 1 chunk +0 lines, -1 line 0 comments Download
M samples-dev/swarm/swarm_ui_lib/base/DomWrapper.dart View 1 chunk +3 lines, -1 line 0 comments Download
M samples-dev/swarm/swarm_ui_lib/base/Env.dart View 1 chunk +1 line, -2 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/base/Size.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/base/base.dart View 1 chunk +1 line, -0 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/layout/GridLayout.dart View 12 chunks +25 lines, -36 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/layout/GridLayoutParams.dart View 3 chunks +16 lines, -18 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/layout/GridLayoutParser.dart View 4 chunks +17 lines, -18 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/layout/GridTracks.dart View 8 chunks +14 lines, -15 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/layout/SizingFunctions.dart View 6 chunks +15 lines, -9 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/layout/ViewLayout.dart View 4 chunks +4 lines, -8 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/observable/ChangeEvent.dart View 1 chunk +8 lines, -3 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/observable/EventBatch.dart View 2 chunks +1 line, -2 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/observable/observable.dart View 12 chunks +29 lines, -23 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/BezierPhysics.dart View 4 chunks +11 lines, -9 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/ClickBuster.dart View 3 chunks +17 lines, -17 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/EventUtil.dart View 2 chunks +9 lines, -6 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/FxUtil.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/Geometry.dart View 4 chunks +2 lines, -6 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/InfiniteScroller.dart View 3 chunks +14 lines, -12 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/Momentum.dart View 18 chunks +53 lines, -60 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/ScrollWatcher.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/Scrollbar.dart View 9 chunks +61 lines, -65 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/Scroller.dart View 17 chunks +67 lines, -70 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/TouchHandler.dart View 6 chunks +23 lines, -18 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/touch/TouchUtil.dart View 8 chunks +109 lines, -43 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/util/CollectionUtils.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/util/DateUtils.dart View 6 chunks +29 lines, -7 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/util/StringUtils.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples-dev/swarm/swarm_ui_lib/util/Uri.dart View 2 chunks +14 lines, -12 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/view/CompositeView.dart View 3 chunks +24 lines, -21 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/view/ConveyorView.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/view/MeasureText.dart View 5 chunks +7 lines, -8 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/view/PagedViews.dart View 7 chunks +19 lines, -24 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/view/SliderMenu.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M samples-dev/swarm/swarm_ui_lib/view/view.dart View 6 chunks +12 lines, -14 lines 0 comments Download
M samples-dev/swarm/test/swarm_test.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M samples-dev/swarm/test/swarm_ui_lib/layout/css.dart View 14 chunks +216 lines, -215 lines 0 comments Download
M samples-dev/swarm/test/swarm_ui_lib/layout/grid_layout_demo.dart View 4 chunks +11 lines, -7 lines 0 comments Download
M samples-dev/swarm/test/swarm_ui_lib/observable/abstract_observable_tests.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M samples-dev/swarm/test/swarm_ui_lib/observable/change_event_tests.dart View 1 chunk +15 lines, -6 lines 0 comments Download
M samples-dev/swarm/test/swarm_ui_lib/observable/observable_list_tests.dart View 2 chunks +12 lines, -10 lines 0 comments Download
M samples-dev/swarm/test/swarm_ui_lib/observable/observable_value_tests.dart View 1 chunk +3 lines, -1 line 0 comments Download
M samples-dev/swarm/test/swarm_ui_lib/touch/touch_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples-dev/swarm/test/swarm_ui_lib/view/view_test.dart View 12 chunks +47 lines, -16 lines 0 comments Download
M samples/build_dart/build.dart View 3 chunks +10 lines, -13 lines 0 comments Download
M samples/build_dart/test/build_dart_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M samples/build_dart_simple/test/build_dart_simple_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M samples/sample_extension/sample_asynchronous_extension.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/sample_extension/test/sample_extension_test_helper.dart View 2 chunks +11 lines, -9 lines 0 comments Download
M samples/sample_extension/test_sample_asynchronous_extension.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
Make sure swarm output size does not regress :)
3 years, 8 months ago (2017-04-18 21:32:19 UTC) #2
sra1
LGTM! swarm dart2js js output is identical
3 years, 8 months ago (2017-04-18 21:37:32 UTC) #3
Jacob
3 years, 8 months ago (2017-04-19 14:30:24 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b33097b9b475db75ccd41bb7ebfdc4e9a4b53559 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698