Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2828573004: [turbofan] Fix typing rule for JSCreateArguments. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix typing rule for JSCreateArguments. The typing rule for JSCreateArguments must properly declare rest parameters as arrays and only consider sloppy and strict arguments objects as Type::OtherObject. TBR=jarin@chromium.org BUG=v8:6262, chromium:712802 Review-Url: https://codereview.chromium.org/2828573004 Cr-Commit-Position: refs/heads/master@{#44712} Committed: https://chromium.googlesource.com/v8/v8/+/b89ddcf1fc657a1689fe0e88d4441bdce54837c3

Patch Set 1 #

Patch Set 2 : Also fix the verifier. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M src/compiler/typer.cc View 1 chunk +9 lines, -1 line 0 comments Download
M src/compiler/types.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-712802.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-19 06:40:49 UTC) #1
Benedikt Meurer
3 years, 8 months ago (2017-04-19 06:42:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828573004/1
3 years, 8 months ago (2017-04-19 06:42:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/builds/4482) v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 8 months ago (2017-04-19 07:03:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828573004/20001
3 years, 8 months ago (2017-04-19 07:09:32 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 07:38:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b89ddcf1fc657a1689fe0e88d4441bdce54...

Powered by Google App Engine
This is Rietveld 408576698