Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: src/compiler/verifier.cc

Issue 2828573004: [turbofan] Fix typing rule for JSCreateArguments. (Closed)
Patch Set: Also fix the verifier. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/types.h ('k') | test/mjsunit/regress/regress-crbug-712802.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 580 matching lines...) Expand 10 before | Expand all | Expand 10 after
591 case IrOpcode::kJSToObject: 591 case IrOpcode::kJSToObject:
592 // Type is Receiver. 592 // Type is Receiver.
593 CheckTypeIs(node, Type::Receiver()); 593 CheckTypeIs(node, Type::Receiver());
594 break; 594 break;
595 595
596 case IrOpcode::kJSCreate: 596 case IrOpcode::kJSCreate:
597 // Type is Object. 597 // Type is Object.
598 CheckTypeIs(node, Type::Object()); 598 CheckTypeIs(node, Type::Object());
599 break; 599 break;
600 case IrOpcode::kJSCreateArguments: 600 case IrOpcode::kJSCreateArguments:
601 // Type is OtherObject. 601 // Type is Array \/ OtherObject.
602 CheckTypeIs(node, Type::OtherObject()); 602 CheckTypeIs(node, Type::ArrayOrOtherObject());
603 break; 603 break;
604 case IrOpcode::kJSCreateArray: 604 case IrOpcode::kJSCreateArray:
605 // Type is Array. 605 // Type is Array.
606 CheckTypeIs(node, Type::Array()); 606 CheckTypeIs(node, Type::Array());
607 break; 607 break;
608 case IrOpcode::kJSCreateClosure: 608 case IrOpcode::kJSCreateClosure:
609 // Type is Function. 609 // Type is Function.
610 CheckTypeIs(node, Type::Function()); 610 CheckTypeIs(node, Type::Function());
611 break; 611 break;
612 case IrOpcode::kJSCreateIterResultObject: 612 case IrOpcode::kJSCreateIterResultObject:
(...skipping 1150 matching lines...) Expand 10 before | Expand all | Expand 10 after
1763 replacement->op()->EffectOutputCount() > 0); 1763 replacement->op()->EffectOutputCount() > 0);
1764 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1764 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1765 replacement->opcode() == IrOpcode::kFrameState); 1765 replacement->opcode() == IrOpcode::kFrameState);
1766 } 1766 }
1767 1767
1768 #endif // DEBUG 1768 #endif // DEBUG
1769 1769
1770 } // namespace compiler 1770 } // namespace compiler
1771 } // namespace internal 1771 } // namespace internal
1772 } // namespace v8 1772 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/types.h ('k') | test/mjsunit/regress/regress-crbug-712802.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698