CSS Motion Path: delete implementation of motion shorthand

CSS Motion Path: delete implementation of motion shorthand

The 'motion' shorthand is among the properties disabled in M58.

Intent to remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/o1C5NzGf9Q0/FgU5o52yBAAJ

BUG=711937
Review-Url: https://codereview.chromium.org/2828503002
Cr-Commit-Position: refs/heads/master@{#465520}
Committed: https://chromium.googlesource.com/chromium/src/+/e2d081bda60e36d5f51c270f809c896bbf473f72

[Eric Willigers, 2017-04-18 11:32:45]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 11:32:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-04-18 11:35:48]

ericwilligers@chromium.org changed reviewers:
+ bugsnash@chromium.org, shans@chromium.org

[Eric Willigers, 2017-04-18 11:35:48]

There hasn't been any last minute uptick in usage of the 5 properties we
deprecated/removed, so we can lock in the removal and delete the dead code.

This is the first of 5 patches.

[commit-bot: I haz the power, 2017-04-18 13:41:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 13:41:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Bugs Nash, 2017-04-19 03:15:05]

https://codereview.chromium.org/2828503002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset.html
(left):

https://codereview.chromium.org/2828503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset.html:12: var
CSSMotionInEffect = 1616; // From UseCounter.h
CSSMotionInEffect hasn't been removed from UseCounter yet (and looks like it
won't until CSSPropertyAliasMotionPath is removed). Perhaps removing it from
this test should wait until then?

[Bugs Nash, 2017-04-19 03:22:50]

On 2017/04/19 at 03:15:05, Bugs Nash wrote:
>
https://codereview.chromium.org/2828503002/diff/1/third_party/WebKit/LayoutTe...
> File third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset.html
(left):
> 
>
https://codereview.chromium.org/2828503002/diff/1/third_party/WebKit/LayoutTe...
> third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset.html:12: var
CSSMotionInEffect = 1616; // From UseCounter.h
> CSSMotionInEffect hasn't been removed from UseCounter yet (and looks like it
won't until CSSPropertyAliasMotionPath is removed). Perhaps removing it from
this test should wait until then?


Should CSSPorpertyMotion be deleted from CSSPropertyNames.cpp too?

[Eric Willigers, 2017-04-19 03:50:52]

On 2017/04/19 03:22:50, Bugs Nash wrote:
> Should CSSPorpertyMotion be deleted from CSSPropertyNames.cpp too?

CSSPropertyNames.cpp is generated. CSSPropertyMotion is
automatically deleted from the generated CSSPropertyNames.cpp
simply by removing "motion" from CSSProperties.json5

[Eric Willigers, 2017-04-19 03:53:28]

https://codereview.chromium.org/2828503002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset.html
(left):

https://codereview.chromium.org/2828503002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/motion-path/use-count-offset.html:12: var
CSSMotionInEffect = 1616; // From UseCounter.h
On 2017/04/19 03:15:04, Bugs Nash wrote:
> CSSMotionInEffect hasn't been removed from UseCounter yet (and looks like it
> won't until CSSPropertyAliasMotionPath is removed). Perhaps removing it from
> this test should wait until then?

OK. Leaving this file unchanged for now.

[Bugs Nash, 2017-04-19 04:04:54]

On 2017/04/19 at 03:50:52, ericwilligers wrote:
> On 2017/04/19 03:22:50, Bugs Nash wrote:
> > Should CSSPorpertyMotion be deleted from CSSPropertyNames.cpp too?
> 
> CSSPropertyNames.cpp is generated. CSSPropertyMotion is
> automatically deleted from the generated CSSPropertyNames.cpp
> simply by removing "motion" from CSSProperties.json5

oh excellent, sorry i missed that. are there any other changes to generated
files? if so can you please create a gist with the changes to the generated
files? You create a gist with the old files, then update it with the new files.
E.g. like in https://codereview.chromium.org/2824993002

Darren has written a python script to make this easy (useful if you're making
lots of changes that impact generated files) which you can find here:
https://gist.github.com/darrnshn/5b36692391313793994c3c8e650cd45a

[Eric Willigers, 2017-04-19 04:54:37]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 04:54:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2017-04-19 05:10:42]

On 2017/04/19 04:04:54, Bugs Nash wrote:
> On 2017/04/19 at 03:50:52, ericwilligers wrote:
> > On 2017/04/19 03:22:50, Bugs Nash wrote:
> > > Should CSSPorpertyMotion be deleted from CSSPropertyNames.cpp too?
> > 
> > CSSPropertyNames.cpp is generated. CSSPropertyMotion is
> > automatically deleted from the generated CSSPropertyNames.cpp
> > simply by removing "motion" from CSSProperties.json5
> 
> oh excellent, sorry i missed that. are there any other changes to generated
> files? if so can you please create a gist with the changes to the generated
> files? You create a gist with the old files, then update it with the new
files.
> E.g. like in https://codereview.chromium.org/2824993002
> 
> Darren has written a python script to make this easy (useful if you're making
> lots of changes that impact generated files) which you can find here:
> https://gist.github.com/darrnshn/5b36692391313793994c3c8e650cd45a


Here is the gist I obtained using that script:
https://gist.github.com/ewilligers/050aa6076ce175ef76429ddf84d5a528/revisions

I am not convinced it is correct or useful. The change to CSSProperties.json5
is trivial and I am not changing the code generation algorithm.

Nothing other than the CSSProperties.json5 change is changing generated code.

[Bugs Nash, 2017-04-19 05:21:46]

On 2017/04/19 at 05:10:42, ericwilligers wrote:
> On 2017/04/19 04:04:54, Bugs Nash wrote:
> > On 2017/04/19 at 03:50:52, ericwilligers wrote:
> > > On 2017/04/19 03:22:50, Bugs Nash wrote:
> > > > Should CSSPorpertyMotion be deleted from CSSPropertyNames.cpp too?
> > > 
> > > CSSPropertyNames.cpp is generated. CSSPropertyMotion is
> > > automatically deleted from the generated CSSPropertyNames.cpp
> > > simply by removing "motion" from CSSProperties.json5
> > 
> > oh excellent, sorry i missed that. are there any other changes to generated
> > files? if so can you please create a gist with the changes to the generated
> > files? You create a gist with the old files, then update it with the new
files.
> > E.g. like in https://codereview.chromium.org/2824993002
> > 
> > Darren has written a python script to make this easy (useful if you're
making
> > lots of changes that impact generated files) which you can find here:
> > https://gist.github.com/darrnshn/5b36692391313793994c3c8e650cd45a
> 
> 
> Here is the gist I obtained using that script:
> https://gist.github.com/ewilligers/050aa6076ce175ef76429ddf84d5a528/revisions
> 
> I am not convinced it is correct or useful. The change to CSSProperties.json5
> is trivial and I am not changing the code generation algorithm.
> 
> Nothing other than the CSSProperties.json5 change is changing generated code.

Thanks Eric! I (and other relative newbies) find these useful when you don't
fully understand how code generation works and what impact changing files like
CSSProperties.json5 really has.

[Bugs Nash, 2017-04-19 05:31:51]

On 2017/04/19 at 05:21:46, Bugs Nash wrote:
> On 2017/04/19 at 05:10:42, ericwilligers wrote:
> > On 2017/04/19 04:04:54, Bugs Nash wrote:
> > > On 2017/04/19 at 03:50:52, ericwilligers wrote:
> > > > On 2017/04/19 03:22:50, Bugs Nash wrote:
> > > > > Should CSSPorpertyMotion be deleted from CSSPropertyNames.cpp too?
> > > > 
> > > > CSSPropertyNames.cpp is generated. CSSPropertyMotion is
> > > > automatically deleted from the generated CSSPropertyNames.cpp
> > > > simply by removing "motion" from CSSProperties.json5
> > > 
> > > oh excellent, sorry i missed that. are there any other changes to
generated
> > > files? if so can you please create a gist with the changes to the
generated
> > > files? You create a gist with the old files, then update it with the new
files.
> > > E.g. like in https://codereview.chromium.org/2824993002
> > > 
> > > Darren has written a python script to make this easy (useful if you're
making
> > > lots of changes that impact generated files) which you can find here:
> > > https://gist.github.com/darrnshn/5b36692391313793994c3c8e650cd45a
> > 
> > 
> > Here is the gist I obtained using that script:
> >
https://gist.github.com/ewilligers/050aa6076ce175ef76429ddf84d5a528/revisions
> > 
> > I am not convinced it is correct or useful. The change to
CSSProperties.json5
> > is trivial and I am not changing the code generation algorithm.
> > 
> > Nothing other than the CSSProperties.json5 change is changing generated
code.
> 
> Thanks Eric! I (and other relative newbies) find these useful when you don't
fully understand how code generation works and what impact changing files like
CSSProperties.json5 really has.

lgtm, and hooray for deleting code!!!

[Eric Willigers, 2017-04-19 05:39:38]

ericwilligers@chromium.org changed reviewers:
+ foolip@chromium.org

[Rick Byers, 2017-04-19 05:56:51]

Description was changed from

==========
CSS Motion Path: delete implementation of motion shorthand

The 'motion' shorthand is among the properties disabled in M58.

BUG=711937
==========

to

==========
CSS Motion Path: delete implementation of motion shorthand

The 'motion' shorthand is among the properties disabled in M58.

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/o1C5NzGf9Q0/Fg...

BUG=711937
==========

[Rick Byers, 2017-04-19 05:58:00]

rbyers@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2017-04-19 05:58:00]

webexposed LGTM

I added a link to the intent to your CL description.

[commit-bot: I haz the power, 2017-04-19 06:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 06:35:54]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Eric Willigers, 2017-04-19 07:05:39]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2017-04-19 07:06:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 07:45:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492585539236170,
"parent_rev": "22b07a940d99a190bf2ccbf0c95ad66dff03526e", "commit_rev":
"e2d081bda60e36d5f51c270f809c896bbf473f72"}

[commit-bot: I haz the power, 2017-04-19 07:45:56]

Description was changed from

==========
CSS Motion Path: delete implementation of motion shorthand

The 'motion' shorthand is among the properties disabled in M58.

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/o1C5NzGf9Q0/Fg...

BUG=711937
==========

to

==========
CSS Motion Path: delete implementation of motion shorthand

The 'motion' shorthand is among the properties disabled in M58.

Intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/o1C5NzGf9Q0/Fg...

BUG=711937

Review-Url: https://codereview.chromium.org/2828503002
Cr-Commit-Position: refs/heads/master@{#465520}
Committed:
https://chromium.googlesource.com/chromium/src/+/e2d081bda60e36d5f51c270f809c...
==========

[commit-bot: I haz the power, 2017-04-19 07:45:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e2d081bda60e36d5f51c270f809c...