Implemented CSSPropertyAPI for transform property.

Implemented CSSPropertyAPI for transform property.

Implemented CSSPropertyAPI for transform property with parseSingleValue
method.

This patch
- added CSSPropertyAPITransform.cpp with parseSingleValue method
- moved parsing logic for transform property from
  CSSPropertyParser::ParseSingleValue to
  CSSPropertyAPITransform::parseSingleValue
- moved helper methods used from CSSPropertyParser to an unnamed
  namespace in CSSPropertyAPITransform
- added CSSPropertyAPITransform implementation data to
  CSSProperties.json5 so that generated files for the API will be
  updated.

Diffs in generated files:
https://gist.github.com/BugsNash/b847d3875db665dc9d57ec984c2174c0/revisions

BUG=668012
Review-Url: https://codereview.chromium.org/2824993002
Cr-Commit-Position: refs/heads/master@{#465917}
Committed: https://chromium.googlesource.com/chromium/src/+/b72ac686eb305a9201b6410c8918637415d204fc

[Bugs Nash, 2017-04-18 05:47:13]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 05:47:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 07:49:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 07:49:44]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2017-04-19 01:41:34]

Description was changed from

==========
Implemented CSSPropertyAPI for transform property.

Implemented CSSPropertyAPI for transform property with parseSingleValue
method.

This patch
- added CSSPropertyAPITransform.cpp with parseSingleValue method
- moved parsing logic for transform property from
  CSSPropertyParser::ParseSingleValue to
  CSSPropertyAPITransform::parseSingleValue
- moved helper methods used from CSSPropertyParser to an unnamed
  namespace in CSSPropertyAPITransform
- added CSSPropertyAPITransform implementation data to
  CSSProperties.json5 so that generated files for the API will be
  updated.

Diffs in generated files:


BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for transform property.

Implemented CSSPropertyAPI for transform property with parseSingleValue
method.

This patch
- added CSSPropertyAPITransform.cpp with parseSingleValue method
- moved parsing logic for transform property from
  CSSPropertyParser::ParseSingleValue to
  CSSPropertyAPITransform::parseSingleValue
- moved helper methods used from CSSPropertyParser to an unnamed
  namespace in CSSPropertyAPITransform
- added CSSPropertyAPITransform implementation data to
  CSSProperties.json5 so that generated files for the API will be
  updated.

Diffs in generated files:
https://gist.github.com/BugsNash/b847d3875db665dc9d57ec984c2174c0/revisions

BUG=668012
==========

[Bugs Nash, 2017-04-19 01:42:25]

bugsnash@chromium.org changed reviewers:
+ nainar@chromium.org

[Bugs Nash, 2017-04-19 01:42:31]

bugsnash@chromium.org changed reviewers:
- nainar@chromium.org

[Bugs Nash, 2017-04-19 21:38:16]

bugsnash@chromium.org changed reviewers:
+ nainar@chromium.org

[nainar, 2017-04-19 23:18:32]

lgtm

[Bugs Nash, 2017-04-19 23:31:28]

bugsnash@chromium.org changed reviewers:
+ alancutter@chromium.org

[Bugs Nash, 2017-04-19 23:31:29]

+alancutter for owners

[alancutter (OOO until 2018), 2017-04-20 03:33:12]

lgtm

https://codereview.chromium.org/2824993002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransform.cpp
(right):

https://codereview.chromium.org/2824993002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransform.cpp:27:
!CSSPropertyParserHelpers::ConsumeCommaIncludingWhitespace(args))
Let's give multiline ifs braces in this file (and optionally give control
structures braces).

[Bugs Nash, 2017-04-20 04:01:21]

addressed review

[Bugs Nash, 2017-04-20 04:01:37]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-04-20 04:01:37]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2824993002/#ps20001
(title: "addressed review")

[Bugs Nash, 2017-04-20 04:01:52]

https://codereview.chromium.org/2824993002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransform.cpp
(right):

https://codereview.chromium.org/2824993002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPITransform.cpp:27:
!CSSPropertyParserHelpers::ConsumeCommaIncludingWhitespace(args))
On 2017/04/20 at 03:33:12, alancutter wrote:
> Let's give multiline ifs braces in this file (and optionally give control
structures braces).


Done.

[commit-bot: I haz the power, 2017-04-20 04:02:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-04-20 04:06:02]

The CQ bit was unchecked by bugsnash@chromium.org

[Bugs Nash, 2017-04-20 04:09:16]

fixed if braces

[Bugs Nash, 2017-04-20 04:09:52]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-04-20 04:09:52]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2824993002/#ps40001
(title: "fixed if braces")

[commit-bot: I haz the power, 2017-04-20 04:10:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 06:26:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492661392321800,
"parent_rev": "1b0bb2fe0fb6094a235a10b4e7d921c9b04e6d2e", "commit_rev":
"b72ac686eb305a9201b6410c8918637415d204fc"}

[commit-bot: I haz the power, 2017-04-20 06:26:46]

Description was changed from

==========
Implemented CSSPropertyAPI for transform property.

Implemented CSSPropertyAPI for transform property with parseSingleValue
method.

This patch
- added CSSPropertyAPITransform.cpp with parseSingleValue method
- moved parsing logic for transform property from
  CSSPropertyParser::ParseSingleValue to
  CSSPropertyAPITransform::parseSingleValue
- moved helper methods used from CSSPropertyParser to an unnamed
  namespace in CSSPropertyAPITransform
- added CSSPropertyAPITransform implementation data to
  CSSProperties.json5 so that generated files for the API will be
  updated.

Diffs in generated files:
https://gist.github.com/BugsNash/b847d3875db665dc9d57ec984c2174c0/revisions

BUG=668012
==========

to

==========
Implemented CSSPropertyAPI for transform property.

Implemented CSSPropertyAPI for transform property with parseSingleValue
method.

This patch
- added CSSPropertyAPITransform.cpp with parseSingleValue method
- moved parsing logic for transform property from
  CSSPropertyParser::ParseSingleValue to
  CSSPropertyAPITransform::parseSingleValue
- moved helper methods used from CSSPropertyParser to an unnamed
  namespace in CSSPropertyAPITransform
- added CSSPropertyAPITransform implementation data to
  CSSProperties.json5 so that generated files for the API will be
  updated.

Diffs in generated files:
https://gist.github.com/BugsNash/b847d3875db665dc9d57ec984c2174c0/revisions

BUG=668012

Review-Url: https://codereview.chromium.org/2824993002
Cr-Commit-Position: refs/heads/master@{#465917}
Committed:
https://chromium.googlesource.com/chromium/src/+/b72ac686eb305a9201b6410c8918...
==========

[commit-bot: I haz the power, 2017-04-20 06:26:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b72ac686eb305a9201b6410c8918...