Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2828493003: Move FindInPagesCoordinates.* from web/ -> core/editing/. (Closed)

Created:
3 years, 8 months ago by slangley
Modified:
3 years, 8 months ago
Reviewers:
haraken, joelhockey
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move FindInPagesCoordinates.* from web/ -> core/editing/. We are in the progress of removing Source/web/, and relocating files to an approprirate place in modules/ or core/. FindInPagesCoordinates has no dependencies on anything in web/ and core/editing/ seems the best future home for this class. For detailed design doc on the process of moving from web/ please refer to the doc at http://bit.ly/2njib8d. BUG=708879 Review-Url: https://codereview.chromium.org/2828493003 Cr-Commit-Position: refs/heads/master@{#465519} Committed: https://chromium.googlesource.com/chromium/src/+/22b07a940d99a190bf2ccbf0c95ad66dff03526e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -231 lines) Patch
M third_party/WebKit/Source/core/editing/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/editing/FindInPageCoordinates.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/core/editing/FindInPageCoordinates.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/web/FindInPageCoordinates.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/web/FindInPageCoordinates.cpp View 1 chunk +0 lines, -158 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
slangley
3 years, 8 months ago (2017-04-19 03:39:33 UTC) #2
joelhockey
lgtm Maybe put the link to the design doc in the bug, and then you ...
3 years, 8 months ago (2017-04-19 03:52:36 UTC) #3
slangley
3 years, 8 months ago (2017-04-19 03:54:02 UTC) #6
haraken
LGTM
3 years, 8 months ago (2017-04-19 05:34:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828493003/1
3 years, 8 months ago (2017-04-19 05:46:04 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 07:33:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/22b07a940d99a190bf2ccbf0c95a...

Powered by Google App Engine
This is Rietveld 408576698