Issue 2828443002: Fix the Update Permissions infobar for geolocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2828443002: Fix the Update Permissions infobar for geolocation. (Closed)

Created:
3 years, 8 months ago by benwells

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3029

Project:
chromium

Visibility:
Public.

Fix the Update Permissions infobar for geolocation. Due to some earlier changes to do with mapping chrome to android permissions, this infobar incorrectly thinks there are multiple permissions being requested for geolocation. BUG=709206 Review-Url: https://codereview.chromium.org/2807093002 Cr-Commit-Position: refs/heads/master@{#463418} (cherry picked from commit d3a2a83fbff70f8beb2f1bbdf691fc2cbb27ea0d) Review-Url: https://codereview.chromium.org/2828443002 . Cr-Commit-Position: refs/branch-heads/3029@{#739} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/eebbac03043ca5ee7eccf0c40285b9fbcf3f4e22

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/permissions/permission_update_infobar_delegate_android.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

benwells

3 years, 8 months ago (2017-04-18 04:29:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
eebbac03043ca5ee7eccf0c40285b9fbcf3f4e22.