Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2807093002: Fix the Update Permissions infobar for geolocation. (Closed)

Created:
3 years, 8 months ago by benwells
Modified:
3 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the Update Permissions infobar for geolocation. Due to some earlier changes to do with mapping chrome to android permissions, this infobar incorrectly thinks there are multiple permissions being requested for geolocation. BUG=709206 Review-Url: https://codereview.chromium.org/2807093002 Cr-Commit-Position: refs/heads/master@{#463418} Committed: https://chromium.googlesource.com/chromium/src/+/d3a2a83fbff70f8beb2f1bbdf691fc2cbb27ea0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/permissions/permission_update_infobar_delegate_android.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
benwells
3 years, 8 months ago (2017-04-10 09:42:49 UTC) #6
Ted C
lgtm D'oh, I thought I had made that change O specific, but forgot that it ...
3 years, 8 months ago (2017-04-10 13:16:06 UTC) #7
benwells
On 2017/04/10 13:16:06, Ted C wrote: > lgtm > > D'oh, I thought I had ...
3 years, 8 months ago (2017-04-10 22:07:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2807093002/1
3 years, 8 months ago (2017-04-10 22:08:00 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 22:20:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3a2a83fbff70f8beb2f1bbdf691...

Powered by Google App Engine
This is Rietveld 408576698