Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2828403002: Revert of Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop.... (Closed)

Created:
3 years, 8 months ago by tdanderson
Modified:
3 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, eroman, tfarina, achuith+watch_chromium.org, bnc+watch_chromium.org, darin-cc_chromium.org, vabr+watchlistlogin_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, mmenke, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop. (patchset #3 id… (patchset #11 id:200001 of https://codereview.chromium.org/2740783003/ ) Reason for revert: Probable cause for failing browser test NavigatingExtensionPopupBrowserTest.DownloadViaPost in https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests/builds/11339 Original issue's description: > Reland #2: Switch WindowedNotificationObserver to use base::RunLoop. > > Now it will quit the message loop immediately after receiving the > notification. Also it does not allow nested tasks anymore. > > Previous CL (https://codereview.chromium.org/2720513003) is in patchset #1. > Added fixes for: > - browser_tests.NavigatingExtensionPopupBrowserTest.DownloadViaPost with PlzNavigate; > - interactive_ui_tests.ConstrainedWindowViewTest.NavigationOnBackspace. > Also rephrased comment in print_preview_dialog_controller_browsertest.cc. > > BUG=668707 > > Review-Url: https://codereview.chromium.org/2740783003 > Cr-Commit-Position: refs/heads/master@{#466016} > Committed: https://chromium.googlesource.com/chromium/src/+/25911df55b8f939560df1f664f8cc8941ddc4677 TBR=jam@chromium.org,vabr@chromium.org,ahest@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668707

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -250 lines) Patch
M chrome/browser/apps/drive/drive_app_provider_browsertest.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_extension_test_notification_observer.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm View 2 chunks +4 lines, -33 lines 0 comments Download
M chrome/browser/ui/login/login_handler_browsertest.cc View 2 chunks +89 lines, -88 lines 0 comments Download
M chrome/browser/ui/login/login_handler_test_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/login/login_handler_test_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/find_bar_views_interactive_uitest.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 2 chunks +25 lines, -51 lines 0 comments Download
M chrome/browser/unload_browsertest.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M content/public/test/test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/test/extension_test_notification_observer.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (10 generated)
tdanderson
Created Revert of Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop. (patchset #3 id…
3 years, 8 months ago (2017-04-20 19:08:58 UTC) #2
tdanderson
3 years, 8 months ago (2017-04-20 20:54:36 UTC) #12
On 2017/04/20 19:08:58, tdanderson wrote:
> Created Revert of Revert "Revert of Reland: Switch
WindowedNotificationObserver
> to use base::RunLoop. (patchset #3 id…

The bots seem to have cycled green without this revert landing,
so I am going to close it out.

Powered by Google App Engine
This is Rietveld 408576698