Reland: Switch WindowedNotificationObserver to use base::RunLoop.

Reland: Switch WindowedNotificationObserver to use base::RunLoop.

Now it will quit the message loop immediately after receiving the
notification. Also it does not allow nested tasks anymore.

Relanding after fixing test failures (bugs 695835, 695780).

Original CL (https://codereview.chromium.org/2701473007) is in patchset #1.

BUG=668707
Review-Url: https://codereview.chromium.org/2720513003
Cr-Commit-Position: refs/heads/master@{#454872}
Committed: https://chromium.googlesource.com/chromium/src/+/d6ecbaf377cb296924168a77832c80ef53c75667

[Alexander Semashko, 2017-02-27 10:30:34]

Description was changed from

==========
Reland: Switch WindowedNotificationObserver to use base::RunLoop.

Now it will quit the message loop immediately after receiving the
notification. Also it does not allow nested tasks anymore.

Relanding after fixing test failures.

BUG=668707, 695835, 695780
==========

to

==========
Reland: Switch WindowedNotificationObserver to use base::RunLoop.

Now it will quit the message loop immediately after receiving the
notification. Also it does not allow nested tasks anymore.

Relanding after fixing test failures.

Original CL (https://codereview.chromium.org/2701473007) is in patchset #1.

BUG=668707, 695835, 695780
==========

[Alexander Semashko, 2017-02-27 15:14:52]

Description was changed from

==========
Reland: Switch WindowedNotificationObserver to use base::RunLoop.

Now it will quit the message loop immediately after receiving the
notification. Also it does not allow nested tasks anymore.

Relanding after fixing test failures.

Original CL (https://codereview.chromium.org/2701473007) is in patchset #1.

BUG=668707, 695835, 695780
==========

to

==========
Reland: Switch WindowedNotificationObserver to use base::RunLoop.

Now it will quit the message loop immediately after receiving the
notification. Also it does not allow nested tasks anymore.

Relanding after fixing test failures (bugs 695835, 695780).

Original CL (https://codereview.chromium.org/2701473007) is in patchset #1.

BUG=668707
==========

[Alexander Semashko, 2017-02-27 15:15:33]

The CQ bit was checked by ahest@yandex-team.ru to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 15:15:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 16:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 16:09:01]

Dry run: This issue passed the CQ dry run.

[Alexander Semashko, 2017-02-27 18:16:22]

ahest@yandex-team.ru changed reviewers:
+ bartfab@chromium.org

[Alexander Semashko, 2017-02-27 18:16:23]

bartfab, can you take a look at
chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc
and https://bugs.chromium.org/p/chromium/issues/detail?id=695073#c1 ?

[Alexander Semashko, 2017-03-03 11:32:53]

PTAL

[Alexander Semashko, 2017-03-06 10:27:01]

ahest@yandex-team.ru changed reviewers:
+ jochen@chromium.org, rdevlin.cronin@chromium.org

[Alexander Semashko, 2017-03-06 10:27:02]

Please take a look at this again.

rdevlin.cronin@chromium.org: Please review changes in chrome/ and content/

jochen@chromium.org: Please review changes in extensions/

[Devlin, 2017-03-06 15:12:02]

On 2017/03/06 10:27:02, Alexander Semashko wrote:
> Please take a look at this again.
> 
> mailto:rdevlin.cronin@chromium.org: Please review changes in chrome/ and
content/
> 
> mailto:jochen@chromium.org: Please review changes in extensions/

Assuming you meant me for extensions, and jochen for chrome/ + content/ :)

extensions lgtm

[jochen (gone - plz use gerrit), 2017-03-06 15:12:44]

lgtm

[Alexander Semashko, 2017-03-06 15:13:12]

On 2017/03/06 15:12:02, Devlin wrote:
> On 2017/03/06 10:27:02, Alexander Semashko wrote:
> > Please take a look at this again.
> > 
> > mailto:rdevlin.cronin@chromium.org: Please review changes in chrome/ and
> content/
> > 
> > mailto:jochen@chromium.org: Please review changes in extensions/
> 
> Assuming you meant me for extensions, and jochen for chrome/ + content/ :)

Oh, you're right, of course :)

> 
> extensions lgtm

[Alexander Semashko, 2017-03-06 15:13:42]

The CQ bit was checked by ahest@yandex-team.ru

[commit-bot: I haz the power, 2017-03-06 15:13:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 16:06:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488813222175200,
"parent_rev": "8faedec47ad63dadb7214bd8da34467a0c0edfb0", "commit_rev":
"d6ecbaf377cb296924168a77832c80ef53c75667"}

[commit-bot: I haz the power, 2017-03-06 16:07:33]

Description was changed from

==========
Reland: Switch WindowedNotificationObserver to use base::RunLoop.

Now it will quit the message loop immediately after receiving the
notification. Also it does not allow nested tasks anymore.

Relanding after fixing test failures (bugs 695835, 695780).

Original CL (https://codereview.chromium.org/2701473007) is in patchset #1.

BUG=668707
==========

to

==========
Reland: Switch WindowedNotificationObserver to use base::RunLoop.

Now it will quit the message loop immediately after receiving the
notification. Also it does not allow nested tasks anymore.

Relanding after fixing test failures (bugs 695835, 695780).

Original CL (https://codereview.chromium.org/2701473007) is in patchset #1.

BUG=668707

Review-Url: https://codereview.chromium.org/2720513003
Cr-Commit-Position: refs/heads/master@{#454872}
Committed:
https://chromium.googlesource.com/chromium/src/+/d6ecbaf377cb296924168a77832c...
==========

[commit-bot: I haz the power, 2017-03-06 16:07:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d6ecbaf377cb296924168a77832c...

[jam, 2017-03-07 19:24:26]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2737823002/ by jam@chromium.org.

The reason for reverting is: Sorry, I realize this isn't on a waterfall yet but
we're very closed to launching PlzNavigate.

I bisected the failure of NavigatingExtensionPopupBrowserTest.DownloadViaPost on
Mac with --enable-browser-side-navigation.

[chanli1, 2017-03-07 23:25:24]

chanli@google.com changed reviewers:
+ chanli@google.com

[chanli1, 2017-03-07 23:25:25]

Hi,

Based on
https://findit-for-me.appspot.com/waterfall/check-flake?key=ag9zfmZpbmRpdC1mb...
and
https://findit-for-me.appspot.com/waterfall/check-flake?key=ag9zfmZpbmRpdC1mb...

I think this CL may cause ConstrainedWindowViewTest.NavigationOnBackspace  to be
flaky. Could you help me to verify if this is the case?

[Alexander Semashko, 2017-03-08 09:45:51]

On 2017/03/07 23:25:25, chanli1 wrote:
> Hi,
> 
> Based on
>
https://findit-for-me.appspot.com/waterfall/check-flake?key=ag9zfmZpbmRpdC1mb...
> and
>
https://findit-for-me.appspot.com/waterfall/check-flake?key=ag9zfmZpbmRpdC1mb...
> 
> I think this CL may cause ConstrainedWindowViewTest.NavigationOnBackspace  to
be
> flaky. Could you help me to verify if this is the case?

Ok, I will look into it.