chrome/browser/extensions/chrome_extension_test_notification_observer.cc - Issue 2828403002: Revert of Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_test_notification_observer.cc

Issue 2828403002: Revert of Revert "Revert of Reland: Switch WindowedNotificationObserver to use base::RunLoop.... (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/login_manager_test.cc ('k') | chrome/browser/printing/print_preview_dialog_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_extension_test_notification_observer.cc

diff --git a/chrome/browser/extensions/chrome_extension_test_notification_observer.cc b/chrome/browser/extensions/chrome_extension_test_notification_observer.cc

index cf28829595ad10711b0fe7db184fd3163cc7cbfa..7a34f44879910aad22c8a6e5cea6878e09da2dbe 100644

--- a/chrome/browser/extensions/chrome_extension_test_notification_observer.cc

+++ b/chrome/browser/extensions/chrome_extension_test_notification_observer.cc

@@ -11,7 +11,6 @@

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/web_contents.h"

-#include "content/public/test/test_utils.h"

#include "extensions/browser/notification_types.h"

#include "extensions/browser/process_manager.h"

#include "extensions/common/extension.h"

@@ -81,10 +80,6 @@

}

bool ChromeExtensionTestNotificationObserver::WaitForExtensionViewsToLoad() {

- // Some views might be not created yet. This call may become insufficient if

- // e.g. implementation of ExtensionHostQueue changes.

- content::RunAllPendingInMessageLoop();

ProcessManager* manager = ProcessManager::Get(GetBrowserContext());

NotificationSet notification_set;

notification_set.Add(content::NOTIFICATION_WEB_CONTENTS_DESTROYED);