Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2828353002: Android: Remove GetApplicationContext part 3 (Closed)

Created:
3 years, 8 months ago by Peter Wen
Modified:
3 years, 8 months ago
Reviewers:
brettw, agrieve
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, avayvod+watch_chromium.org, agrieve+watch_chromium.org, chrome-grc-reviews+memory_chromium.org, mlamouri+watch-media_chromium.org, cbentzel+watch_chromium.org, iclelland+watch_chromium.org, jam, chasej+watch_chromium.org, net-reviews_chromium.org, nona+watch_chromium.org, einbinder+watch-test-runner_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, feature-media-reviews_chromium.org, kalyank, jochen+watch_chromium.org, David Trainor- moved to gerrit, mlamouri+watch-test-runner_chromium.org, shuchen+watch_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Remove GetApplicationContext part 3 Java-side already has the ContextUtils#GetApplicationContext global and no longer needs native to hold the pointer and pass it through jni with every call that needs an application context. Part 1: https://codereview.chromium.org/2772343003/ Part 2: https://codereview.chromium.org/2799263002/ Part 2.1 (cast): http://crrev.com/2807263002 Part 2.2 (components): http://crrev.com/2810863003 BUG=646094 Review-Url: https://codereview.chromium.org/2828353002 Cr-Commit-Position: refs/heads/master@{#466622} Committed: https://chromium.googlesource.com/chromium/src/+/8fc10285e6e66ddc3bfdc48e84e3efaac6a025dd

Patch Set 1 #

Patch Set 2 : Fix android webview tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -223 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ContentViewMiscTest.java View 1 4 chunks +9 lines, -13 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/RecentTabsTest.java View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/android/background_sync_network_observer_android.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/android/composited_touch_handle_drawable.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/java_interfaces_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/child_process_launcher_helper_android.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/media/android/media_resource_getter_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/media/session/audio_focus_delegate_android.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/memory/memory_monitor_android.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/speech/speech_recognizer_impl_android.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/AudioFocusDelegate.java View 4 chunks +8 lines, -8 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/BackgroundSyncNetworkObserver.java View 5 chunks +11 lines, -12 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java View 1 chunk +7 lines, -8 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrarImpl.java View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java View 2 chunks +4 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MemoryMonitorAndroid.java View 4 chunks +7 lines, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SpeechRecognition.java View 5 chunks +11 lines, -8 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/HandleViewResources.java View 2 chunks +6 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/InterfaceRegistrar.java View 2 chunks +4 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/scoped_android_configuration.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/android/cellular_signal_strength.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M net/android/java/src/org/chromium/net/AndroidCellularSignalStrength.java View 5 chunks +13 lines, -10 lines 0 comments Download
M net/android/java/src/org/chromium/net/AndroidNetworkLibrary.java View 11 chunks +23 lines, -20 lines 0 comments Download
M net/android/java/src/org/chromium/net/NetworkChangeNotifier.java View 3 chunks +9 lines, -6 lines 0 comments Download
M net/android/java/src/org/chromium/net/NetworkChangeNotifierAutoDetect.java View 6 chunks +9 lines, -9 lines 0 comments Download
M net/android/java/src/org/chromium/net/ProxyChangeListener.java View 5 chunks +6 lines, -8 lines 0 comments Download
M net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java View 11 chunks +11 lines, -18 lines 0 comments Download
M net/android/network_change_notifier_delegate_android.cc View 2 chunks +1 line, -4 lines 0 comments Download
M net/android/network_library.cc View 4 chunks +9 lines, -19 lines 0 comments Download
M net/cert/x509_util_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/proxy/proxy_config_service_android.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Peter Wen
The end is neigh! 🎠 This and probably one more, plus a couple internal ones ...
3 years, 8 months ago (2017-04-20 17:16:06 UTC) #4
agrieve
lgtm
3 years, 8 months ago (2017-04-20 17:52:50 UTC) #5
Peter Wen
+brettw@ for global OWNERS. This and only one (I hope) CL more to finish this ...
3 years, 8 months ago (2017-04-20 19:48:14 UTC) #9
brettw
lgtm
3 years, 8 months ago (2017-04-21 17:37:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828353002/20001
3 years, 8 months ago (2017-04-24 12:24:16 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 13:38:22 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8fc10285e6e66ddc3bfdc48e84e3...

Powered by Google App Engine
This is Rietveld 408576698