Copy the {credentials,cache,redirect,} modes for Fetch Requests

Copy the {credentials,cache,redirect,} modes for Fetch Requests

These four properties were not being copied over when populating a
WebServiceWorkerRequest from a Request. These properties are
already being copied over when converting in the other direction
in FetchRequestData::Create().

BUG=

Review-Url: https://codereview.chromium.org/2828293002
Cr-Commit-Position: refs/heads/master@{#467685}
Committed: https://chromium.googlesource.com/chromium/src/+/560458ed6c19491dc39cb5a6f5317cc0a9d705df

[Peter Beverloo, 2017-04-20 14:15:26]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 14:15:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2017-04-20 14:17:23]

peter@chromium.org changed reviewers:
+ horo@chromium.org, yhirano@chromium.org

[Peter Beverloo, 2017-04-20 14:17:24]

+yhirano, would you mind taking a look?

[commit-bot: I haz the power, 2017-04-20 16:10:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 16:10:19]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-04-21 01:41:18]

On 2017/04/20 14:17:24, Peter Beverloo wrote:
> +yhirano, would you mind taking a look?

Is this change observable from layout tests?

[Peter Beverloo, 2017-04-21 01:45:44]

On 2017/04/21 01:41:18, yhirano wrote:
> On 2017/04/20 14:17:24, Peter Beverloo wrote:
> > +yhirano, would you mind taking a look?
> 
> Is this change observable from layout tests?

No, not yet. They will be once the Background Fetch layout test machinery
improves.

[yhirano, 2017-04-21 03:05:35]

description:

", or the other way around."

Can you tell me what this means? IIUC changes in both files are in (Request =>
WebServiceWorkerRequest) direction.

[horo, 2017-04-21 09:09:38]

Code changes lgtm.
Please refine the cl description as yhirano@ is saying.

[Peter Beverloo, 2017-04-27 13:58:13]

Description was changed from

==========
Copy the {credentials,cache,redirect,} modes for Fetch Requests

These four properties were not being copied over when populating a
WebServiceWorkerRequest from a Request, or the other way around.

BUG=
==========

to

==========
Copy the {credentials,cache,redirect,} modes for Fetch Requests

These four properties were not being copied over when populating a
WebServiceWorkerRequest from a Request. These properties are
already being copied over when converting in the other direction
in FetchRequestData::Create().

BUG=
==========

[Peter Beverloo, 2017-04-27 13:58:44]

Thank you both, done!

I've updated that phrase to read: "These properties are being copied over when
converting in the other direction
in FetchRequestData::Create()."

https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/fetch/...

So we're now consistent.

[Peter Beverloo, 2017-04-27 13:58:48]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2017-04-27 13:59:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yhirano, 2017-04-27 14:36:57]

lgtm

[commit-bot: I haz the power, 2017-04-27 15:27:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493301528090120, "parent_rev":
"71552a7a961db97918872b48032cf8d98a95cb66", "commit_rev":
"560458ed6c19491dc39cb5a6f5317cc0a9d705df"}

[commit-bot: I haz the power, 2017-04-27 15:27:27]

Description was changed from

==========
Copy the {credentials,cache,redirect,} modes for Fetch Requests

These four properties were not being copied over when populating a
WebServiceWorkerRequest from a Request. These properties are
already being copied over when converting in the other direction
in FetchRequestData::Create().

BUG=
==========

to

==========
Copy the {credentials,cache,redirect,} modes for Fetch Requests

These four properties were not being copied over when populating a
WebServiceWorkerRequest from a Request. These properties are
already being copied over when converting in the other direction
in FetchRequestData::Create().

BUG=

Review-Url: https://codereview.chromium.org/2828293002
Cr-Commit-Position: refs/heads/master@{#467685}
Committed:
https://chromium.googlesource.com/chromium/src/+/560458ed6c19491dc39cb5a6f531...
==========

[commit-bot: I haz the power, 2017-04-27 15:27:28]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/560458ed6c19491dc39cb5a6f531...