Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: third_party/WebKit/Source/modules/fetch/RequestTest.cpp

Issue 2828293002: Copy the {credentials,cache,redirect,} modes for Fetch Requests (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Request.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/fetch/RequestTest.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/RequestTest.cpp b/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
index b94e41e18b2aaebc0ba485718d1fc81031d5355b..a03e31700ddb72438e0b05165eaba274c5d27cef 100644
--- a/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
+++ b/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
@@ -62,11 +62,20 @@ TEST(ServiceWorkerRequestTest, FromAndToWebRequest) {
WebURLRequest::kRequestContextAudio;
const WebURLRequest::FetchRequestMode kMode =
WebURLRequest::kFetchRequestModeNavigate;
+ const WebURLRequest::FetchCredentialsMode kCredentialsMode =
+ WebURLRequest::kFetchCredentialsModeInclude;
+ const WebURLRequest::FetchRequestCacheMode kCacheMode =
+ WebURLRequest::kFetchRequestCacheModeNoCache;
+ const WebURLRequest::FetchRedirectMode kRedirectMode =
+ WebURLRequest::kFetchRedirectModeError;
web_request.SetURL(url);
web_request.SetMethod(method);
- web_request.SetRequestContext(kContext);
web_request.SetMode(kMode);
+ web_request.SetCredentialsMode(kCredentialsMode);
+ web_request.SetCacheMode(kCacheMode);
+ web_request.SetRedirectMode(kRedirectMode);
+ web_request.SetRequestContext(kContext);
for (int i = 0; headers[i].key; ++i)
web_request.SetHeader(WebString::FromUTF8(headers[i].key),
WebString::FromUTF8(headers[i].value));
@@ -97,11 +106,14 @@ TEST(ServiceWorkerRequestTest, FromAndToWebRequest) {
request->PopulateWebServiceWorkerRequest(second_web_request);
EXPECT_EQ(url, KURL(second_web_request.Url()));
EXPECT_EQ(method, String(second_web_request.Method()));
+ EXPECT_EQ(kMode, second_web_request.Mode());
+ EXPECT_EQ(kCredentialsMode, second_web_request.CredentialsMode());
+ EXPECT_EQ(kCacheMode, second_web_request.CacheMode());
+ EXPECT_EQ(kRedirectMode, second_web_request.RedirectMode());
EXPECT_EQ(kContext, second_web_request.GetRequestContext());
EXPECT_EQ(referrer, KURL(second_web_request.ReferrerUrl()));
EXPECT_EQ(kWebReferrerPolicyAlways, second_web_request.GetReferrerPolicy());
EXPECT_EQ(web_request.Headers(), second_web_request.Headers());
- EXPECT_EQ(WebURLRequest::kFetchRequestModeNoCORS, second_web_request.Mode());
}
TEST(ServiceWorkerRequestTest, ToWebRequestStripsURLFragment) {
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/Request.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698