Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2828143002: [test/inspector] migrate utils to ObjectTemplate (Closed)

Created:
3 years, 8 months ago by kozy
Modified:
3 years, 8 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[test/inspector] migrate utils to ObjectTemplate v8::Extension should be replaced with ObjectTemplates. So let's not use it for utils. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2828143002 Cr-Commit-Position: refs/heads/master@{#44754} Committed: https://chromium.googlesource.com/v8/v8/+/f4721a5f30a5a4c57f34b7ee522c8ffa30dbe353

Patch Set 1 #

Patch Set 2 : dont use deprecated NewFromUtf8 #

Patch Set 3 : say no for deprecated methods! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -142 lines) Patch
M test/inspector/inspector-test.cc View 1 2 4 chunks +54 lines, -112 lines 0 comments Download
M test/inspector/protocol-test.js View 1 chunk +0 lines, -30 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
kozy
Dmitry, please take a look. Ideally we should setup all necessary functions and objects on ...
3 years, 8 months ago (2017-04-20 01:41:51 UTC) #1
dgozman
lgtm
3 years, 8 months ago (2017-04-20 16:41:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828143002/20001
3 years, 8 months ago (2017-04-20 17:17:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/17067)
3 years, 8 months ago (2017-04-20 17:25:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828143002/40001
3 years, 8 months ago (2017-04-20 17:33:07 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 18:04:33 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/f4721a5f30a5a4c57f34b7ee522c8ffa30d...

Powered by Google App Engine
This is Rietveld 408576698