Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2827953003: Follow-up fix to change in Git module (r465813) (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow-up fix to change in Git module (r465813) In https://codereview.chromium.org/2818223002, I accidentally removed a `return` that shouldn't have been removed. BUG=711088 Review-Url: https://codereview.chromium.org/2827953003 Cr-Commit-Position: refs/heads/master@{#466064} Committed: https://chromium.googlesource.com/chromium/src/+/699ff2a6613e4dbd2b9357f4845c687e7104f41c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
3 years, 8 months ago (2017-04-20 01:14:26 UTC) #2
jeffcarp
lgtm
3 years, 8 months ago (2017-04-20 16:38:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827953003/1
3 years, 8 months ago (2017-04-20 16:54:09 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 17:56:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/699ff2a6613e4dbd2b9357f4845c...

Powered by Google App Engine
This is Rietveld 408576698