Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2818223002: Change GitCL to initialize git executable name on Windows. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change GitCL to initialize git executable name on Windows. BUG=711088 Review-Url: https://codereview.chromium.org/2818223002 Cr-Commit-Position: refs/heads/master@{#465813} Committed: https://chromium.googlesource.com/chromium/src/+/f2a0b8e1353add967a367b5ce57b41ddbc1546e3

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -33 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git.py View 1 3 chunks +18 lines, -24 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/git_mock.py View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
qyearsley
3 years, 8 months ago (2017-04-19 02:25:58 UTC) #10
qyearsley
3 years, 8 months ago (2017-04-19 02:26:10 UTC) #11
jeffcarp
lgtm
3 years, 8 months ago (2017-04-19 23:40:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2818223002/40001
3 years, 8 months ago (2017-04-19 23:43:23 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 23:48:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f2a0b8e1353add967a367b5ce57b...

Powered by Google App Engine
This is Rietveld 408576698