Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2827773002:
[MD settings] align mouse and touchpad page (Closed)
|
Created:
3 years, 8 months ago by dschuyler Modified:
3 years, 8 months ago Reviewers:
stevenjb CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] align mouse and touchpad page
This CL changes some padding and margins in the page layout for the mouse
and touchpad settings on chromeos.
BUG=712478
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2827773002
Cr-Commit-Position: refs/heads/master@{#465368}
Committed: https://chromium.googlesource.com/chromium/src/+/e4a5dd4fe77a84d1da83efb0e99b217da512a50e
Patch Set 1 #
Total comments: 2
Messages
Total messages: 15 (9 generated)
Description was changed from ========== [MD settings] align mouse and touchpad page This CL changes some padding and margins in the page layout for the mouse and touchpad settings on chromeos. BUG=712478 ========== to ========== [MD settings] align mouse and touchpad page This CL changes some padding and margins in the page layout for the mouse and touchpad settings on chromeos. BUG=712478 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + stevenjb@chromium.org
https://codereview.chromium.org/2827773002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/device_page/pointers.html (right): https://codereview.chromium.org/2827773002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/device_page/pointers.html:29: <div class$="[[getSubsectionClass_(hasMouse, hasTouchpad)]]"> Lines 30 to 48 should be indented without other changes. https://codereview.chromium.org/2827773002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/device_page/pointers.html:55: <div class$="[[getSubsectionClass_(hasMouse, hasTouchpad)]]"> Lines 56 to 92 should be indented without other changes.
On 2017/04/18 19:40:59, dschuyler wrote: > https://codereview.chromium.org/2827773002/diff/1/chrome/browser/resources/se... > File chrome/browser/resources/settings/device_page/pointers.html (right): > > https://codereview.chromium.org/2827773002/diff/1/chrome/browser/resources/se... > chrome/browser/resources/settings/device_page/pointers.html:29: <div > class$="[[getSubsectionClass_(hasMouse, hasTouchpad)]]"> > Lines 30 to 48 should be indented without other changes. > > https://codereview.chromium.org/2827773002/diff/1/chrome/browser/resources/se... > chrome/browser/resources/settings/device_page/pointers.html:55: <div > class$="[[getSubsectionClass_(hasMouse, hasTouchpad)]]"> > Lines 56 to 92 should be indented without other changes. Before and after screen shots in bug.
Ugh, why are these diffs so awful? Any way we could reduce WS changes to improve the diff? Assuming that the CSS is the main change, this lgtm.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/04/18 20:16:49, stevenjb wrote: > Ugh, why are these diffs so awful? Any way we could reduce WS changes to improve > the diff? I wonder if the 'differ' could be improved. It would be unfortunate to make code changes to help a diff tool imo. > > Assuming that the CSS is the main change, this lgtm.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492548730846720, "parent_rev":
"7df0af6216babebfbe1a71090bac6b8397d9ae7c", "commit_rev":
"e4a5dd4fe77a84d1da83efb0e99b217da512a50e"}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] align mouse and touchpad page This CL changes some padding and margins in the page layout for the mouse and touchpad settings on chromeos. BUG=712478 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] align mouse and touchpad page This CL changes some padding and margins in the page layout for the mouse and touchpad settings on chromeos. BUG=712478 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2827773002 Cr-Commit-Position: refs/heads/master@{#465368} Committed: https://chromium.googlesource.com/chromium/src/+/e4a5dd4fe77a84d1da83efb0e99b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e4a5dd4fe77a84d1da83efb0e99b... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
