Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/browser/resources/settings/device_page/pointers.html

Issue 2827773002: [MD settings] align mouse and touchpad page (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/pape r-radio-button.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-radio-button/pape r-radio-button.html">
3 <link rel="import" href="../controls/settings_radio_group.html"> 3 <link rel="import" href="../controls/settings_radio_group.html">
4 <link rel="import" href="../controls/settings_slider.html"> 4 <link rel="import" href="../controls/settings_slider.html">
5 <link rel="import" href="../controls/settings_toggle_button.html"> 5 <link rel="import" href="../controls/settings_toggle_button.html">
6 <link rel="import" href="device_page_browser_proxy.html"> 6 <link rel="import" href="device_page_browser_proxy.html">
7 <link rel="import" href="../settings_shared_css.html"> 7 <link rel="import" href="../settings_shared_css.html">
8 8
9 <dom-module id="settings-pointers"> 9 <dom-module id="settings-pointers">
10 <template> 10 <template>
11 <style include="settings-shared"> 11 <style include="settings-shared">
12 h2 { 12 h2 {
13 -webkit-padding-start: var(--settings-box-row-padding); 13 -webkit-padding-start: var(--settings-box-row-padding);
14 } 14 }
15 15
16 /* Indent layout elements under .subsection, using margin instead of 16 .subsection {
17 * padding so the borders line up. */ 17 -webkit-padding-end: var(--settings-box-row-padding);
18 .subsection > .settings-box { 18 -webkit-padding-start: var(--settings-box-row-indent);
19 margin: 0 var(--settings-box-row-indent);
20 padding: 0;
21 } 19 }
22 20
23 .subsection > .list-frame { 21 .subsection > .settings-box {
24 -webkit-margin-start: var(--settings-indent-width); 22 padding-left: 0;
23 padding-right: 0;
25 } 24 }
26 </style> 25 </style>
27 <div id="mouse" hidden$="[[!hasMouse]]" 26 <div id="mouse" hidden$="[[!hasMouse]]">
28 class$="[[getSubsectionClass_(hasMouse, hasTouchpad)]]">
29 <!-- Subsection title only appears if both mouse and touchpad exist. --> 27 <!-- Subsection title only appears if both mouse and touchpad exist. -->
30 <h2 hidden$="[[!hasTouchpad]]">$i18n{mouseTitle}</h2> 28 <h2 hidden$="[[!hasTouchpad]]">$i18n{mouseTitle}</h2>
31 <div class="settings-box first"> 29 <div class$="[[getSubsectionClass_(hasMouse, hasTouchpad)]]">
dschuyler 2017/04/18 19:40:59 Lines 30 to 48 should be indented without other ch
32 <!-- Do not change the mouse button pref before the mouse is released. 30 <div class="settings-box first">
33 See crbug.com/686949 --> 31 <!-- Do not change the mouse button pref before the mouse is released.
34 <settings-toggle-button id="mouseSwapButton" class="start" 32 See crbug.com/686949 -->
35 pref="{{prefs.settings.mouse.primary_right}}" 33 <settings-toggle-button id="mouseSwapButton" class="start"
36 label="$i18n{mouseSwapButtons}" 34 pref="{{prefs.settings.mouse.primary_right}}"
37 on-settings-boolean-control-change="onMouseSwapButtonsChange_" 35 label="$i18n{mouseSwapButtons}"
38 on-down="onMouseSwapButtonsDown_" on-up="onMouseSwapButtonsUp_" 36 on-settings-boolean-control-change="onMouseSwapButtonsChange_"
39 no-set-pref> 37 on-down="onMouseSwapButtonsDown_" on-up="onMouseSwapButtonsUp_"
40 </settings-toggle-button> 38 no-set-pref>
41 </div> 39 </settings-toggle-button>
42 <div class="settings-box"> 40 </div>
43 <div class="start" id="mouseSpeedLabel">$i18n{mouseSpeed}</div> 41 <div class="settings-box">
44 <settings-slider pref="{{prefs.settings.mouse.sensitivity2}}" 42 <div class="start" id="mouseSpeedLabel">$i18n{mouseSpeed}</div>
45 tick-values="[[sensitivityValues_]]" 43 <settings-slider pref="{{prefs.settings.mouse.sensitivity2}}"
46 aria-labelledby="mouseSpeedLabel"
47 label-min="$i18n{pointerSlow}"
48 label-max="$i18n{pointerFast}">
49 </settings-slider>
50 </div>
51 </div>
52 <div id="touchpad" hidden$="[[!hasTouchpad]]"
53 class$="[[getSubsectionClass_(hasMouse, hasTouchpad)]]">
54 <!-- Subsection title only appears if both mouse and touchpad exist. -->
55 <h2 hidden$="[[!hasMouse]]">$i18n{touchpadTitle}</h2>
56 <div class="settings-box block first">
57 <settings-toggle-button id="enableTapToClick"
58 pref="{{prefs.settings.touchpad.enable_tap_to_click}}"
59 label="$i18n{touchpadTapToClickEnabledLabel}">
60 </settings-toggle-button>
61 <settings-toggle-button id="enableTapDragging"
62 pref="{{prefs.settings.touchpad.enable_tap_dragging}}"
63 label="$i18n{tapDraggingLabel}">
64 </settings-toggle-button>
65 </div>
66 <div class="settings-box">
67 <div class="start" id="touchpadSpeedLabel">$i18n{touchpadSpeed}</div>
68 <settings-slider id="touchpadSensitivity"
69 pref="{{prefs.settings.touchpad.sensitivity2}}"
70 tick-values="[[sensitivityValues_]]" 44 tick-values="[[sensitivityValues_]]"
71 aria-labelledby="touchpadSpeedLabel" 45 aria-labelledby="mouseSpeedLabel"
72 label-min="$i18n{pointerSlow}" 46 label-min="$i18n{pointerSlow}"
73 label-max="$i18n{pointerFast}"> 47 label-max="$i18n{pointerFast}">
74 </settings-slider> 48 </settings-slider>
49 </div>
75 </div> 50 </div>
76 <div class="settings-box">$i18n{scrollLabel}</div> 51 </div>
77 <div class="list-frame"> 52 <div id="touchpad" hidden$="[[!hasTouchpad]]">
78 <settings-radio-group pref="{{prefs.settings.touchpad.natural_scroll}}"> 53 <!-- Subsection title only appears if both mouse and touchpad exist. -->
79 <paper-radio-button name="false"> 54 <h2 hidden$="[[!hasMouse]]">$i18n{touchpadTitle}</h2>
80 $i18n{traditionalScrollLabel} 55 <div class$="[[getSubsectionClass_(hasMouse, hasTouchpad)]]">
dschuyler 2017/04/18 19:40:59 Lines 56 to 92 should be indented without other ch
81 </paper-radio-button> 56 <div class="settings-box block first">
82 <paper-radio-button name="true"> 57 <settings-toggle-button id="enableTapToClick"
83 $i18n{naturalScrollLabel} 58 pref="{{prefs.settings.touchpad.enable_tap_to_click}}"
84 <a href="$i18n{naturalScrollLearnMoreLink}" target="_blank" 59 label="$i18n{touchpadTapToClickEnabledLabel}">
85 on-tap="onLearnMoreLinkActivated_" 60 </settings-toggle-button>
86 on-keydown="onLearnMoreLinkActivated_"> 61 <settings-toggle-button id="enableTapDragging"
87 $i18n{naturalScrollLearnMore} 62 pref="{{prefs.settings.touchpad.enable_tap_dragging}}"
88 </a> 63 label="$i18n{tapDraggingLabel}">
89 </paper-radio-button> 64 </settings-toggle-button>
90 </settings-radio-group> 65 </div>
66 <div class="settings-box">
67 <div class="start" id="touchpadSpeedLabel">$i18n{touchpadSpeed}</div>
68 <settings-slider id="touchpadSensitivity"
69 pref="{{prefs.settings.touchpad.sensitivity2}}"
70 tick-values="[[sensitivityValues_]]"
71 aria-labelledby="touchpadSpeedLabel"
72 label-min="$i18n{pointerSlow}"
73 label-max="$i18n{pointerFast}">
74 </settings-slider>
75 </div>
76 <div class="settings-box">$i18n{scrollLabel}</div>
77 <div class="list-frame">
78 <settings-radio-group
79 pref="{{prefs.settings.touchpad.natural_scroll}}">
80 <paper-radio-button name="false">
81 $i18n{traditionalScrollLabel}
82 </paper-radio-button>
83 <paper-radio-button name="true">
84 $i18n{naturalScrollLabel}
85 <a href="$i18n{naturalScrollLearnMoreLink}" target="_blank"
86 on-tap="onLearnMoreLinkActivated_"
87 on-keydown="onLearnMoreLinkActivated_">
88 $i18n{naturalScrollLearnMore}
89 </a>
90 </paper-radio-button>
91 </settings-radio-group>
92 </div>
91 </div> 93 </div>
92 </div> 94 </div>
93 </template> 95 </template>
94 <script src="pointers.js"></script> 96 <script src="pointers.js"></script>
95 </dom-module> 97 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698