[modules] Allow resolve-callback to signal failure.

[modules] Allow resolve-callback to signal failure.

When asked for a module that previously failed to compile or
instantiate, the embedder necessarily has to signal failure.  In this
case, we expect an exception to be scheduled, which we will rethrow.

BUG=v8:1569
Review-Url: https://codereview.chromium.org/2827733002
Cr-Commit-Position: refs/heads/master@{#44729}
Committed: https://chromium.googlesource.com/v8/v8/+/486cd04f3d9a75acb4d9f929b333954b8f59cec0

[neis, 2017-04-18 18:41:18]

Patchset #1 (id:1) has been deleted

[neis, 2017-04-18 18:41:37]

Description was changed from

==========
[modules] Allow resolve-callback to signal failure.

When asked for a module that previously failed to compile or
instantiate, the embedder necessarily has to signal failure.  In this
case, we expect an exception to be scheduled, which we will rethrow.

BUG=
==========

to

==========
[modules] Allow resolve-callback to signal failure.

When asked for a module that previously failed to compile or
instantiate, the embedder necessarily has to signal failure.  In this
case, we expect an exception to be scheduled, which we will rethrow.

BUG=v8:1569
==========

[neis, 2017-04-18 18:43:11]

neis@chromium.org changed reviewers:
+ adamk@chromium.org, hiroshige@chromium.org, kouhei@chromium.org

[neis, 2017-04-18 18:43:11]

ptal

[adamk, 2017-04-18 18:45:46]

I realize that this is best-exercised by a Blink test, but could you write a
simple cctest for this in cctest/test-modules.cc?

[kouhei (in TOK), 2017-04-19 07:14:05]

non-owner lgtm
This works perfectly

[neis, 2017-04-19 08:45:00]

I've updated test-modules.cc.

[neis, 2017-04-19 09:03:57]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 09:04:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 09:33:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 09:33:46]

Dry run: This issue passed the CQ dry run.

[adamk, 2017-04-19 18:26:25]

The CQ bit was checked by adamk@chromium.org

[adamk, 2017-04-19 18:26:25]

lgtm

[adamk, 2017-04-19 18:26:26]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2827733002/#ps80001
(title: "Cleanup.")

[commit-bot: I haz the power, 2017-04-19 18:26:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 18:28:10]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492626385156340,
"parent_rev": "246a7bdd26198ea38d174797160631c6904966b7", "commit_rev":
"486cd04f3d9a75acb4d9f929b333954b8f59cec0"}

[commit-bot: I haz the power, 2017-04-19 18:28:18]

Description was changed from

==========
[modules] Allow resolve-callback to signal failure.

When asked for a module that previously failed to compile or
instantiate, the embedder necessarily has to signal failure.  In this
case, we expect an exception to be scheduled, which we will rethrow.

BUG=v8:1569
==========

to

==========
[modules] Allow resolve-callback to signal failure.

When asked for a module that previously failed to compile or
instantiate, the embedder necessarily has to signal failure.  In this
case, we expect an exception to be scheduled, which we will rethrow.

BUG=v8:1569

Review-Url: https://codereview.chromium.org/2827733002
Cr-Commit-Position: refs/heads/master@{#44729}
Committed:
https://chromium.googlesource.com/v8/v8/+/486cd04f3d9a75acb4d9f929b333954b8f5...
==========

[commit-bot: I haz the power, 2017-04-19 18:28:19]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/486cd04f3d9a75acb4d9f929b333954b8f5...