Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 2827733002: [modules] Allow resolve-callback to signal failure. (Closed)

Created:
3 years, 8 months ago by neis
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Allow resolve-callback to signal failure. When asked for a module that previously failed to compile or instantiate, the embedder necessarily has to signal failure. In this case, we expect an exception to be scheduled, which we will rethrow. BUG=v8:1569 Review-Url: https://codereview.chromium.org/2827733002 Cr-Commit-Position: refs/heads/master@{#44729} Committed: https://chromium.googlesource.com/v8/v8/+/486cd04f3d9a75acb4d9f929b333954b8f59cec0

Patch Set 1 #

Patch Set 2 : Update tests. #

Patch Set 3 : Check exception value. #

Patch Set 4 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -17 lines) Patch
M include/v8.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -6 lines 0 comments Download
M test/cctest/test-modules.cc View 1 2 3 7 chunks +36 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
neis
ptal
3 years, 8 months ago (2017-04-18 18:43:11 UTC) #4
adamk
I realize that this is best-exercised by a Blink test, but could you write a ...
3 years, 8 months ago (2017-04-18 18:45:46 UTC) #5
kouhei (in TOK)
non-owner lgtm This works perfectly
3 years, 8 months ago (2017-04-19 07:14:05 UTC) #6
neis
I've updated test-modules.cc.
3 years, 8 months ago (2017-04-19 08:45:00 UTC) #7
adamk
lgtm
3 years, 8 months ago (2017-04-19 18:26:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827733002/80001
3 years, 8 months ago (2017-04-19 18:26:35 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 18:28:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/486cd04f3d9a75acb4d9f929b333954b8f5...

Powered by Google App Engine
This is Rietveld 408576698