Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: include/v8.h

Issue 2827733002: [modules] Allow resolve-callback to signal failure. (Closed)
Patch Set: Cleanup. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index accc280c32c0c715cf7bc2db4616c763d40e52ae..2a747957958a4cb08eee92ed7634b518fc3aaad7 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1095,7 +1095,8 @@ class V8_EXPORT Module {
/**
* ModuleDeclarationInstantiation
*
- * Returns false if an exception occurred during instantiation.
+ * Returns false if an exception occurred during instantiation. (In the case
+ * where the callback throws an exception, that exception is propagated.)
*/
V8_WARN_UNUSED_RESULT bool Instantiate(Local<Context> context,
ResolveCallback callback);
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698