Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2827673005: Fix bug in webkitpy/w3c/directory_owners_extractor.py (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, ortuno
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug in webkitpy/w3c/directory_owners_extractor.py Specifically, in cases like: # Owners: foo@chromium.org # directory1 [ Pass ] # Owners: nobody # directory2 [ Pass ] the function lines_to_owner_map was associating directory2 with foo@chromium.org even though owners should have been reset in this case. BUG=712888 Review-Url: https://codereview.chromium.org/2827673005 Cr-Commit-Position: refs/heads/master@{#465838} Committed: https://chromium.googlesource.com/chromium/src/+/54d7e3050af7ebb57aa7cd99cef14037db03f3bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
qyearsley
3 years, 8 months ago (2017-04-18 23:39:21 UTC) #2
jeffcarp
lgtm
3 years, 8 months ago (2017-04-19 23:40:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827673005/1
3 years, 8 months ago (2017-04-19 23:43:57 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 01:00:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/54d7e3050af7ebb57aa7cd99cef1...

Powered by Google App Engine
This is Rietveld 408576698