Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py

Issue 2827673005: Fix bug in webkitpy/w3c/directory_owners_extractor.py (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py
index 213e436bbcb2489c2933b022a1ac10b3567e8acf..bf6ee437dd36814169899b58e6f223b698c18d00 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor_unittest.py
@@ -26,7 +26,6 @@ class DirectoryOwnersExtractorTest(unittest.TestCase):
'# external/wpt/webstorage [ Pass ]',
'external/wpt/webvtt [ Skip ]',
]
-
self.assertEqual(
self.extractor.lines_to_owner_map(lines),
{
@@ -35,6 +34,20 @@ class DirectoryOwnersExtractorTest(unittest.TestCase):
'external/wpt/webstorage': ['michaeln@chromium.org', 'jsbell@chromium.org'],
})
+ def test_lines_to_owner_map_no_owners(self):
+ lines = [
+ '## Owners: someone@chromium.org',
+ '# external/wpt/something [ Pass ]',
+ '## Owners: explicitly no owners but still enabled',
+ '# external/wpt/common [ Pass ]',
+ ]
+ self.assertEqual(
+ self.extractor.lines_to_owner_map(lines),
+ {
+ 'external/wpt/something': ['someone@chromium.org'],
+ })
+
+
def test_list_owners(self):
self.extractor.owner_map = {
'external/wpt/foo': ['a@chromium.org', 'c@chromium.org'],
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/directory_owners_extractor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698