Fix tab width and icon padding in CBD

Fix tab width and icon padding in CBD

Change TabLayout to use the full width of the screen even in landscape
orientation and on larger screens.
Increase the padding of preference icons to match the padding of "Time
range". (like SiteSettingsPreference)

Before:
https://screenshot.googleplex.com/BZvpCHXTHqf.png

After:
https://screenshot.googleplex.com/ZOPvbyXz0AV.png


BUG=681523
Review-Url: https://codereview.chromium.org/2827653004
Cr-Commit-Position: refs/heads/master@{#465954}
Committed: https://chromium.googlesource.com/chromium/src/+/827d8ad5f022cbc1a904a159f0041b5fc5afca6c

[dullweber, 2017-04-19 11:16:37]

Description was changed from

==========
Fix tab width and icon padding in CBD

Change TabLayout to use the full width of the screen even in landscape
orientation.
Increase the padding of preference icons to match the padding of "Time
range". (like SiteSettingsPreference)

BUG=681523
==========

to

==========
Fix tab width and icon padding in CBD

Change TabLayout to use the full width of the screen even in landscape
orientation.
Increase the padding of preference icons to match the padding of "Time
range". (like SiteSettingsPreference)

Before:
https://screenshot.googleplex.com/ZOPvbyXz0AV.png

After:
https://screenshot.googleplex.com/BZvpCHXTHqf.png

BUG=681523
==========

[dullweber, 2017-04-19 11:21:36]

dullweber@chromium.org changed reviewers:
+ twellington@chromium.org

[dullweber, 2017-04-19 11:21:37]

twellington@chromium.org: Please review this change. 

I don't know, why site_setttings_icon_padding was exactly 4.6dp but I decided to
use the same value as there was probably a reason for it and it looks fine :D

[dullweber, 2017-04-19 11:29:41]

Description was changed from

==========
Fix tab width and icon padding in CBD

Change TabLayout to use the full width of the screen even in landscape
orientation.
Increase the padding of preference icons to match the padding of "Time
range". (like SiteSettingsPreference)

Before:
https://screenshot.googleplex.com/ZOPvbyXz0AV.png

After:
https://screenshot.googleplex.com/BZvpCHXTHqf.png

BUG=681523
==========

to

==========
Fix tab width and icon padding in CBD

Change TabLayout to use the full width of the screen even in landscape
orientation and on larger screens.
Increase the padding of preference icons to match the padding of "Time
range". (like SiteSettingsPreference)

Before:
https://screenshot.googleplex.com/ZOPvbyXz0AV.png

After:
https://screenshot.googleplex.com/BZvpCHXTHqf.png

BUG=681523
==========

[Theresa, 2017-04-19 15:04:05]

On 2017/04/19 11:21:37, dullweber wrote:
> mailto:twellington@chromium.org: Please review this change. 
> 
> I don't know, why site_setttings_icon_padding was exactly 4.6dp but I decided
to
> use the same value as there was probably a reason for it and it looks fine :D

Are the before and after screenshots reversed?
(Is after https://screenshot.googleplex.com/ZOPvbyXz0AV.png ?)

[dullweber, 2017-04-19 15:58:02]

Description was changed from

==========
Fix tab width and icon padding in CBD

Change TabLayout to use the full width of the screen even in landscape
orientation and on larger screens.
Increase the padding of preference icons to match the padding of "Time
range". (like SiteSettingsPreference)

Before:
https://screenshot.googleplex.com/ZOPvbyXz0AV.png

After:
https://screenshot.googleplex.com/BZvpCHXTHqf.png

BUG=681523
==========

to

==========
Fix tab width and icon padding in CBD

Change TabLayout to use the full width of the screen even in landscape
orientation and on larger screens.
Increase the padding of preference icons to match the padding of "Time
range". (like SiteSettingsPreference)

Before:
https://screenshot.googleplex.com/BZvpCHXTHqf.png

After:
https://screenshot.googleplex.com/ZOPvbyXz0AV.png


BUG=681523
==========

[dullweber, 2017-04-19 15:58:42]

On 2017/04/19 15:04:05, Theresa wrote:
> On 2017/04/19 11:21:37, dullweber wrote:
> > mailto:twellington@chromium.org: Please review this change. 
> > 
> > I don't know, why site_setttings_icon_padding was exactly 4.6dp but I
decided
> to
> > use the same value as there was probably a reason for it and it looks fine
:D
> 
> Are the before and after screenshots reversed?
> (Is after https://screenshot.googleplex.com/ZOPvbyXz0AV.png ?)

Oh, yes they are. Thanks, I fixed it

[Theresa, 2017-04-19 17:06:44]

lgtm

[dullweber, 2017-04-20 08:01:19]

The CQ bit was checked by dullweber@chromium.org

[dullweber, 2017-04-20 08:02:01]

The CQ bit was unchecked by dullweber@chromium.org

[commit-bot: I haz the power, 2017-04-20 08:02:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-04-20 08:21:56]

On 2017/04/19 17:06:44, Theresa wrote:
> lgtm

thanks, I just noticed that the padding isn't applied correctly with RTL text
direction, so I replaced icon.setPadding with
ApiCompatibilityUtils.setPaddingRelative in CBDTabCheckboxPreference and
SiteSettingsPreference.

[dullweber, 2017-04-20 08:22:36]

The CQ bit was checked by dullweber@chromium.org

[dullweber, 2017-04-20 08:22:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2827653004/#ps20001
(title: "fix padding in RTL direction")

[commit-bot: I haz the power, 2017-04-20 08:23:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 09:00:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492676556286000,
"parent_rev": "baa7279f62313d4e5b11108c04611d1e79fc04bf", "commit_rev":
"827d8ad5f022cbc1a904a159f0041b5fc5afca6c"}

[commit-bot: I haz the power, 2017-04-20 09:00:57]

Description was changed from

==========
Fix tab width and icon padding in CBD

Change TabLayout to use the full width of the screen even in landscape
orientation and on larger screens.
Increase the padding of preference icons to match the padding of "Time
range". (like SiteSettingsPreference)

Before:
https://screenshot.googleplex.com/BZvpCHXTHqf.png

After:
https://screenshot.googleplex.com/ZOPvbyXz0AV.png


BUG=681523
==========

to

==========
Fix tab width and icon padding in CBD

Change TabLayout to use the full width of the screen even in landscape
orientation and on larger screens.
Increase the padding of preference icons to match the padding of "Time
range". (like SiteSettingsPreference)

Before:
https://screenshot.googleplex.com/BZvpCHXTHqf.png

After:
https://screenshot.googleplex.com/ZOPvbyXz0AV.png


BUG=681523

Review-Url: https://codereview.chromium.org/2827653004
Cr-Commit-Position: refs/heads/master@{#465954}
Committed:
https://chromium.googlesource.com/chromium/src/+/827d8ad5f022cbc1a904a159f004...
==========

[commit-bot: I haz the power, 2017-04-20 09:00:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/827d8ad5f022cbc1a904a159f004...

[Theresa, 2017-04-20 14:48:44]

On 2017/04/20 08:21:56, dullweber wrote:
> On 2017/04/19 17:06:44, Theresa wrote:
> > lgtm
> 
> thanks, I just noticed that the padding isn't applied correctly with RTL text
> direction, so I replaced icon.setPadding with
> ApiCompatibilityUtils.setPaddingRelative in CBDTabCheckboxPreference and
> SiteSettingsPreference.

Good catch, I should have noticed that.