chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java - Issue 2827653004: Fix tab width and icon padding in CBD

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java

Issue 2827653004: Fix tab width and icon padding in CBD (Closed)

Patch Set: fix padding in RTL direction Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/ClearBrowsingDataTabCheckBoxPreference.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java

index 249e6a4453b9bc67d262ee1be9b1d20cef16dc98..bbf6eb6800ee4e7184ca2e7f6580d63db910066a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java

@@ -10,6 +10,7 @@ import android.util.AttributeSet;

import android.view.View;

import android.widget.ImageView;

+import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.chrome.R;

/**

@@ -27,9 +28,9 @@ public class SiteSettingsPreference extends Preference {

protected void onBindView(View view) {

super.onBindView(view);

- int padding = getContext().getResources().getDimensionPixelSize(

- R.dimen.site_setttings_icon_padding);

+ int padding = getContext().getResources().getDimensionPixelSize(R.dimen.pref_icon_padding);

ImageView icon = (ImageView) view.findViewById(android.R.id.icon);

- icon.setPadding(padding, icon.getPaddingTop(), 0, icon.getPaddingBottom());

+ ApiCompatibilityUtils.setPaddingRelative(

+ icon, padding, icon.getPaddingTop(), 0, icon.getPaddingBottom());

}