Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2827483002: Merge M59: "Fix incorrect collation of media logs." (Closed)

Created:
3 years, 8 months ago by DaleCurtis
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge M59: "Fix incorrect collation of media logs." http://crrev.com/463025 incorrectly started using a global MediaLog instance for each RenderFrame. The RendererMediaLog uses an internal counter for routing and collating player logs, so doing this causes all logs for a render frame to end up in the same player. This patch reverts that portion of the change; though it's questionable if WebEncryptedMediaClientImpl() should actually be given a MediaLog just for logging RAPPOR entries. Presumably there is another mechanism that could accomplish this. BUG=695264, 711818 TEST=unittest TBD, manually verified cnn.com, internetradio.com each create a new button entry in chrome://media-internals. Watch time logs are properly recorded. Review-Url: https://codereview.chromium.org/2819973002 Cr-Commit-Position: refs/heads/master@{#464844} (cherry picked from commit f4f7b3aad31bbce44c84dd2cdbd2400a90f87d51) Review-Url: https://codereview.chromium.org/2827483002 . Cr-Commit-Position: refs/branch-heads/3071@{#20} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/0398002f42e790ba37023328f65fdfd5208feac7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M content/renderer/render_frame_impl.h View 3 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 7 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
3 years, 8 months ago (2017-04-17 18:16:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0398002f42e790ba37023328f65fdfd5208feac7.

Powered by Google App Engine
This is Rietveld 408576698