Chromium Code Reviews
DescriptionMerge M59: "Fix incorrect collation of media logs."
http://crrev.com/463025 incorrectly started using a global MediaLog
instance for each RenderFrame. The RendererMediaLog uses an internal
counter for routing and collating player logs, so doing this causes
all logs for a render frame to end up in the same player.
This patch reverts that portion of the change; though it's questionable
if WebEncryptedMediaClientImpl() should actually be given a MediaLog
just for logging RAPPOR entries. Presumably there is another mechanism
that could accomplish this.
BUG=695264, 711818
TEST=unittest TBD, manually verified cnn.com, internetradio.com each create
a new button entry in chrome://media-internals. Watch time logs are properly
recorded.
Review-Url: https://codereview.chromium.org/2819973002
Cr-Commit-Position: refs/heads/master@{#464844}
(cherry picked from commit f4f7b3aad31bbce44c84dd2cdbd2400a90f87d51)
Review-Url: https://codereview.chromium.org/2827483002 .
Cr-Commit-Position: refs/branch-heads/3071@{#20}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}
Committed: https://chromium.googlesource.com/chromium/src/+/0398002f42e790ba37023328f65fdfd5208feac7
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||