Fix incorrect collation of media logs.

Fix incorrect collation of media logs.

http://crrev.com/463025 incorrectly started using a global MediaLog
instance for each RenderFrame. The RendererMediaLog uses an internal
counter for routing and collating player logs, so doing this causes
all logs for a render frame to end up in the same player.

This patch reverts that portion of the change; though it's questionable
if WebEncryptedMediaClientImpl() should actually be given a MediaLog
just for logging RAPPOR entries. Presumably there is another mechanism
that could accomplish this.

BUG=695264, 711818
TEST=unittest TBD, manually verified cnn.com, internetradio.com each create
a new button entry in chrome://media-internals. Watch time logs are properly
recorded.

Review-Url: https://codereview.chromium.org/2819973002
Cr-Commit-Position: refs/heads/master@{#464844}
Committed: https://chromium.googlesource.com/chromium/src/+/f4f7b3aad31bbce44c84dd2cdbd2400a90f87d51

[DaleCurtis, 2017-04-14 22:42:53]

dalecurtis@chromium.org changed reviewers:
+ avi@chromium.org, xhwang@chromium.org

[DaleCurtis, 2017-04-14 22:42:53]

Fixes M59 beta blocker regression in media logging.

[DaleCurtis, 2017-04-14 22:43:27]

Description was changed from

==========
Fix incorrect collation of media logs.

http://crrev.com/463025 incorrectly started using a global MediaLog
instance for each RenderFrame. The RendererMediaLog uses an internal
counter for routing and collating player logs, so doing this causes
all logs for a render frame to end up in the same player.

This patch reverts that portion of the change; though it's questionable
if WebEncryptedMediaClientImpl() should actually be given a MediaLog
just for logging RAPPOR entries. Presumably there is another mechanism
that could accomplish this.

BUG=711818
TEST=TBD
==========

to

==========
Fix incorrect collation of media logs.

http://crrev.com/463025 incorrectly started using a global MediaLog
instance for each RenderFrame. The RendererMediaLog uses an internal
counter for routing and collating player logs, so doing this causes
all logs for a render frame to end up in the same player.

This patch reverts that portion of the change; though it's questionable
if WebEncryptedMediaClientImpl() should actually be given a MediaLog
just for logging RAPPOR entries. Presumably there is another mechanism
that could accomplish this.

BUG=711818
TEST=unittest TBD, manually verified cnn.com, internetradio.com each create
a new button entry in chrome://media-internals. Watch time logs are properly
recorded.
==========

[DaleCurtis, 2017-04-14 22:43:44]

Description was changed from

==========
Fix incorrect collation of media logs.

http://crrev.com/463025 incorrectly started using a global MediaLog
instance for each RenderFrame. The RendererMediaLog uses an internal
counter for routing and collating player logs, so doing this causes
all logs for a render frame to end up in the same player.

This patch reverts that portion of the change; though it's questionable
if WebEncryptedMediaClientImpl() should actually be given a MediaLog
just for logging RAPPOR entries. Presumably there is another mechanism
that could accomplish this.

BUG=711818
TEST=unittest TBD, manually verified cnn.com, internetradio.com each create
a new button entry in chrome://media-internals. Watch time logs are properly
recorded.
==========

to

==========
Fix incorrect collation of media logs.

http://crrev.com/463025 incorrectly started using a global MediaLog
instance for each RenderFrame. The RendererMediaLog uses an internal
counter for routing and collating player logs, so doing this causes
all logs for a render frame to end up in the same player.

This patch reverts that portion of the change; though it's questionable
if WebEncryptedMediaClientImpl() should actually be given a MediaLog
just for logging RAPPOR entries. Presumably there is another mechanism
that could accomplish this.

BUG=695264, 711818
TEST=unittest TBD, manually verified cnn.com, internetradio.com each create
a new button entry in chrome://media-internals. Watch time logs are properly
recorded.
==========

[xhwang, 2017-04-14 22:56:42]

Good catch. LGTM % nit

https://codereview.chromium.org/2819973002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2819973002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:2847: // a new player id which is used to
collate logs on the browser side.
Add a TODO to pass std::unique<MediaLog> here so that WMPI will own it to avoid
this from happening again?

[Avi (use Gerrit), 2017-04-15 00:01:30]

lgtm

stamp

[DaleCurtis, 2017-04-15 00:09:57]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2017-04-15 00:09:58]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2819973002/#ps40001
(title: "Fix typo in comment.")

[commit-bot: I haz the power, 2017-04-15 00:10:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 00:51:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 00:51:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[DaleCurtis, 2017-04-15 01:01:28]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2017-04-15 01:02:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-15 01:22:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492218088862060,
"parent_rev": "7e07864f2ede565e4d3bbb0db34a84825abd6a19", "commit_rev":
"f4f7b3aad31bbce44c84dd2cdbd2400a90f87d51"}

[commit-bot: I haz the power, 2017-04-15 01:22:59]

Description was changed from

==========
Fix incorrect collation of media logs.

http://crrev.com/463025 incorrectly started using a global MediaLog
instance for each RenderFrame. The RendererMediaLog uses an internal
counter for routing and collating player logs, so doing this causes
all logs for a render frame to end up in the same player.

This patch reverts that portion of the change; though it's questionable
if WebEncryptedMediaClientImpl() should actually be given a MediaLog
just for logging RAPPOR entries. Presumably there is another mechanism
that could accomplish this.

BUG=695264, 711818
TEST=unittest TBD, manually verified cnn.com, internetradio.com each create
a new button entry in chrome://media-internals. Watch time logs are properly
recorded.
==========

to

==========
Fix incorrect collation of media logs.

http://crrev.com/463025 incorrectly started using a global MediaLog
instance for each RenderFrame. The RendererMediaLog uses an internal
counter for routing and collating player logs, so doing this causes
all logs for a render frame to end up in the same player.

This patch reverts that portion of the change; though it's questionable
if WebEncryptedMediaClientImpl() should actually be given a MediaLog
just for logging RAPPOR entries. Presumably there is another mechanism
that could accomplish this.

BUG=695264, 711818
TEST=unittest TBD, manually verified cnn.com, internetradio.com each create
a new button entry in chrome://media-internals. Watch time logs are properly
recorded.

Review-Url: https://codereview.chromium.org/2819973002
Cr-Commit-Position: refs/heads/master@{#464844}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4f7b3aad31bbce44c84dd2cdbd2...
==========

[commit-bot: I haz the power, 2017-04-15 01:23:00]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f4f7b3aad31bbce44c84dd2cdbd2...