Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2827473002: Revert of Split PendingScript into PendingScript and ClassicPendingScript (patchset #37 id:720001 o… (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Revert of Split PendingScript into PendingScript and ClassicPendingScript (patchset #37 id:720001 of https://codereview.chromium.org/2653923008/ ) Reason for revert: Suspected to cause CHECK() failure (crbug.com/711703) inside PendingScript's prefinalizer. BUG=711703 Original issue's description: > Split PendingScript into PendingScript and ClassicPendingScript > > This is preparation for introducing ModulePendingScript. > > BUG=594639, 686281 > > Review-Url: https://codereview.chromium.org/2653923008 > Cr-Commit-Position: refs/heads/master@{#464494} > Committed: https://chromium.googlesource.com/chromium/src/+/d512803299c01324b92ffd8c962da97e3bc8ccff TBR=kouhei@chromium.org,sigbjornf@opera.com,japhet@chromium.org,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594639, 686281 Review-Url: https://codereview.chromium.org/2820753002 Cr-Commit-Position: refs/heads/master@{#464768} (cherry picked from commit 56f27b65967e0722581b511fcd03f61d25b991c5) Review-Url: https://codereview.chromium.org/2827473002 . Cr-Commit-Position: refs/branch-heads/3071@{#18} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f41274df3c287d68031e1453c9aeff846c6d4449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -428 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h View 9 chunks +20 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ClassicPendingScript.h View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp View 1 chunk +0 lines, -240 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.h View 4 chunks +52 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 3 chunks +210 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 9 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hiroshige
3 years, 8 months ago (2017-04-17 17:45:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f41274df3c287d68031e1453c9aeff846c6d4449.

Powered by Google App Engine
This is Rietveld 408576698