Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2820753002: Revert of Split PendingScript into PendingScript and ClassicPendingScript (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
CC:
chromium-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, loading-reviews+parser_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Split PendingScript into PendingScript and ClassicPendingScript (patchset #37 id:720001 of https://codereview.chromium.org/2653923008/ ) Reason for revert: Suspected to cause CHECK() failure (crbug.com/711703) inside PendingScript's prefinalizer. BUG=711703 Original issue's description: > Split PendingScript into PendingScript and ClassicPendingScript > > This is preparation for introducing ModulePendingScript. > > BUG=594639, 686281 > > Review-Url: https://codereview.chromium.org/2653923008 > Cr-Commit-Position: refs/heads/master@{#464494} > Committed: https://chromium.googlesource.com/chromium/src/+/d512803299c01324b92ffd8c962da97e3bc8ccff TBR=kouhei@chromium.org,sigbjornf@opera.com,japhet@chromium.org,haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594639, 686281 Review-Url: https://codereview.chromium.org/2820753002 Cr-Commit-Position: refs/heads/master@{#464768} Committed: https://chromium.googlesource.com/chromium/src/+/56f27b65967e0722581b511fcd03f61d25b991c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -431 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h View 9 chunks +20 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ClassicPendingScript.h View 1 chunk +0 lines, -88 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp View 1 chunk +0 lines, -240 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.h View 4 chunks +52 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 3 chunks +213 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 9 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hiroshige
Created Revert of Split PendingScript into PendingScript and ClassicPendingScript
3 years, 8 months ago (2017-04-14 18:28:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820753002/1
3 years, 8 months ago (2017-04-14 18:28:35 UTC) #3
haraken
LGTM
3 years, 8 months ago (2017-04-14 18:29:30 UTC) #4
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/dom/PendingScript.h: While running git apply --index -3 -p1; error: patch ...
3 years, 8 months ago (2017-04-14 18:30:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2820753002/1
3 years, 8 months ago (2017-04-14 19:01:56 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-14 19:03:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/56f27b65967e0722581b511fcd03...

Powered by Google App Engine
This is Rietveld 408576698