Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2827393003: Prevent Android tests from being broken by data URL deprecation (Closed)

Created:
3 years, 8 months ago by meacer
Modified:
3 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent Android tests from being broken by data URL deprecation These tests will be broken when content initiated navigations to data URLs are blocked. This CL navigates the tests to an existing file instead of data URLs. It also removes some unused variables. BUG=594215 Review-Url: https://codereview.chromium.org/2827393003 Cr-Commit-Position: refs/heads/master@{#466200} Committed: https://chromium.googlesource.com/chromium/src/+/699e9524613ff501ac38a231679bca4c2aedeb74

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -112 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java View 2 chunks +19 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java View 7 chunks +62 lines, -5 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/MultiActivityTestBase.java View 3 chunks +0 lines, -104 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
meacer
tedchoc: Can you please take a look? Thanks.
3 years, 8 months ago (2017-04-21 00:10:45 UTC) #8
Ted C
lgtm
3 years, 8 months ago (2017-04-21 00:19:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2827393003/1
3 years, 8 months ago (2017-04-21 00:28:21 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 00:36:36 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/699e9524613ff501ac38a231679b...

Powered by Google App Engine
This is Rietveld 408576698