Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java

Issue 2827393003: Prevent Android tests from being broken by data URL deprecation (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
index bdeecdaeef48affe167fd940e655af7aa903d4e2..6c9620e4449d39eeac056d14fda93274dfc9b22f 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
@@ -24,12 +24,12 @@ import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest;
import org.chromium.base.test.util.RetryOnFailure;
+import org.chromium.base.test.util.UrlUtils;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.tab.EmptyTabObserver;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModelUtils;
import org.chromium.chrome.test.ChromeTabbedActivityTestBase;
-import org.chromium.chrome.test.MultiActivityTestBase;
import org.chromium.chrome.test.util.ApplicationTestUtils;
import org.chromium.chrome.test.util.ChromeTabUtils;
import org.chromium.content.browser.test.util.Criteria;
@@ -633,9 +633,25 @@ public class TabsOpenedFromExternalAppTest extends ChromeTabbedActivityTestBase
}
}));
+ // Defines one gigantic link spanning the whole page that creates a new
+ // window with chrome/test/data/android/google.html.
+ final String hrefLink = UrlUtils.encodeHtmlDataUri("<html>"
+ + " <head>"
+ + " <title>href link page</title>"
+ + " <meta name='viewport'"
+ + " content='width=device-width initial-scale=0.5, maximum-scale=0.5'>"
+ + " <style>"
+ + " body {margin: 0em;} div {width: 100%; height: 100%; background: #011684;}"
+ + " </style>"
+ + " </head>"
+ + " <body>"
+ + " <a href='" + mTestServer.getURL("/chrome/test/data/android/google.html")
+ + "' target='_blank'><div></div></a>"
+ + " </body>"
+ + "</html>");
+
// Open a tab via an external application.
- final Intent intent = new Intent(
- Intent.ACTION_VIEW, Uri.parse(MultiActivityTestBase.HREF_LINK));
+ final Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(hrefLink));
intent.setClassName(getInstrumentation().getTargetContext().getPackageName(),
ChromeTabbedActivity.class.getName());
intent.putExtra(Browser.EXTRA_APPLICATION_ID, "com.legit.totes");
« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappModeTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698