Tighten up handling of JS types and add test.

Tighten up handling of JS types and add test.

Side effect of this:
Fix bug where helpers in js_mirrors were specifying that name had to have type String when it could really also be a JS Symbol as well.
Fix bug where top level JS interop members using the external keyword but no @JS keyword were not implemented.
Update js_typed_interop_test.dart so it can work in DDC.
Add regression test for jsify call with native function type arguments.

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/7149b90c7cee5ebb55479eae630a08f81a8c426d

[Jacob, 2017-04-20 20:03:07]

jacobr@google.com changed reviewers:
+ vsm@google.com

[Jacob, 2017-04-20 20:03:08]

Tighten up handling of JS types.

Fix bug where helpers in js_mirrors were specifying name had type
String when it could really also be a JS Symbol.
Fix bug for top level JS interop members with an external keyword but no
@JS keyword.
Fix type checks for JS interop so they can pass on DDC.
Add regression test for jsify call with native function type arguments.

[vsm, 2017-04-21 12:35:58]

lgtm

https://codereview.chromium.org/2827333003/diff/10001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart
(right):

https://codereview.chromium.org/2827333003/diff/10001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart:453: if
(actual == $jsobject && $isFunctionType(type) && typeof(obj) === 'function')
return true;
nit: line len

https://codereview.chromium.org/2827333003/diff/10001/tests/lib_strong/html/j...
File tests/lib_strong/html/js_typed_interop_test.dart (right):

https://codereview.chromium.org/2827333003/diff/10001/tests/lib_strong/html/j...
tests/lib_strong/html/js_typed_interop_test.dart:250: // tracked for anonymous
JS classes.
Is this a DDC issue?  Either way, file a tracking issue?

[Jacob, 2017-04-21 15:44:11]

Description was changed from

==========
Tighten up handling of JS types and add test.

Side effect of this:
Fix bug where helpers in js_mirrors were specifying that name had to have type
String when it could really also be a JS Symbol as well.
Fix bug where top level JS interop members using the external keyword but no @JS
keyword were not implemented.
Update js_typed_interop_test.dart so it can work in DDC.
Add regression test for jsify call with native function type arguments.

BUG=
==========

to

==========
Tighten up handling of JS types and add test.

Side effect of this:
Fix bug where helpers in js_mirrors were specifying that name had to have type
String when it could really also be a JS Symbol as well.
Fix bug where top level JS interop members using the external keyword but no @JS
keyword were not implemented.
Update js_typed_interop_test.dart so it can work in DDC.
Add regression test for jsify call with native function type arguments.

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7149b90c7cee5ebb55479eae630a08f81a8c426d
==========

[Jacob, 2017-04-21 15:44:12]

Committed patchset #2 (id:10001) manually as
7149b90c7cee5ebb55479eae630a08f81a8c426d (presubmit successful).