Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart

Issue 2827333003: Tighten up handling of JS types and add test. (Closed)
Patch Set: Tighten up handling of JS types. Fix bug where helpers in js_mirrors were specifying name had type … Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart b/pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart
index 98c6dbdcec5429087fa8ccfcf0633c24f57c8b89..9b2d9052f689a60ff329ddcf66ea46022e7b77ed 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart
@@ -49,11 +49,11 @@ TypeMirror reflectType(Type key) {
final dynamic _dart = JS('', 'dart');
-dynamic _dload(obj, String name) {
+dynamic _dload(obj, name) {
return JS('', '#.dloadMirror(#, #)', _dart, obj, name);
}
-void _dput(obj, String name, val) {
+void _dput(obj, name, val) {
JS('', '#.dputMirror(#, #, #)', _dart, obj, name, val);
}
@@ -61,7 +61,7 @@ dynamic _dcall(obj, List args) {
return JS('', '#.dcall(#, ...#)', _dart, obj, args);
}
-dynamic _dsend(obj, String name, List args) {
+dynamic _dsend(obj, name, List args) {
return JS('', '#.dsend(#, #, ...#)', _dart, obj, name, args);
}

Powered by Google App Engine
This is Rietveld 408576698